chore(deps-dev): bump sqlalchemy-hana from 0.4.0 to 3.0.3#41953
Conversation
Code Review Agent Run #f6bb59Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41953 +/- ##
==========================================
- Coverage 64.80% 64.76% -0.05%
==========================================
Files 2740 2742 +2
Lines 153135 153331 +196
Branches 35129 35149 +20
==========================================
+ Hits 99246 99303 +57
- Misses 51991 52121 +130
- Partials 1898 1907 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Same blocker as the databricks bump over in #41954: sqlalchemy-hana 4.x requires That said, 0.4.0 is ancient, and sqlalchemy-hana 3.0.3 still supports |
Retargeted from Dependabot's 4.6.0 proposal: 4.x requires SQLAlchemy 2.0, which conflicts with Superset's `sqlalchemy>=1.4, <2` pin. 3.0.3 still supports `sqlalchemy<3, >=1.4.0`, so it's a large, safe modernization from the ancient 0.4.0 that works with our current SQLAlchemy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rusackas
force-pushed
the
dependabot/pip/sqlalchemy-hana-4.6.0
branch
from
aeb06dc to
e18297d
Compare
rusackas
changed the title
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
Retargeted this from 4.6.0 to 3.0.3, since 4.x wants sqlalchemy>=2 and we're still on sqlalchemy<2. 3.0.3 keeps sqlalchemy<3, >=1.4.0 so it works with our current SQLAlchemy, and it's still a big jump forward from 0.4.0. LGTM, approving!
|
Bito Automatic Review Skipped – PR Already Merged |
1 participant
Bumps sqlalchemy-hana from 0.4.0 to 4.6.0.
Changelog
Sourced from sqlalchemy-hana's changelog.
... (truncated)
Commits
2211e94Bump 4.6.0 (#617)c3eb5cfFix with_for_update of (#627)3def4f7Pin build system tools (#631)1e6eac3Enable pytest strict mode (#632)79134acAvoid duplicate schema names (#625)3d37aceUpdate dependency uv to v0.11.17 (#630)187207eUpdate dependency flake8-tergeo to v26.5.28.0 (#629)d91d5abUpdate dependency coverage to v7.14.1 (#628)4edee32Remove 2.1 from CI (#626)2df6993Update dependency diff-cover to v10.2.1 (#624)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)