build(deps): update @rjsf deps to v6#41955
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
…nt resource utilization Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
requested review from
betodealmeida,
dpgaspar,
eschutho,
geido,
kgabryje,
mistercrunch,
nytai,
rusackas,
sadpandajoe,
sha174n and
villebro
as code owners
dosubot
Bot
added
dependencies:npm
javascript
Code Review Agent Run #240dbaActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
…g transformed by Jest Signed-off-by: hainenber <dotronghai96@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41955 +/- ##
==========================================
+ Coverage 64.88% 64.91% +0.02%
==========================================
Files 2742 2740 -2
Lines 153378 153102 -276
Branches 35168 35139 -29
==========================================
- Hits 99516 99380 -136
+ Misses 51958 51826 -132
+ Partials 1904 1896 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code Review Agent Run #517682Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
| // @ant-design/icons >= 6.3 deep-imports the ESM build of @ant-design/colors | ||
| // from its CJS output, so babel-jest must transform those files. | ||
| 'node_modules/(?!@ant-design/(colors|fast-color)|@formatjs/.*|d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|(?!geostyler)lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect|react-diff-viewer-continued|storybook/*.|json-stringify-pretty-compact)', | ||
| 'node_modules/(?!@ant-design/(colors|fast-color)|@formatjs/.*|d3-(array|interpolate|color|time|scale|time-format|format)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|uuid|@rjsf/*.|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|(?!geostyler)lodash|react-error-boundary|react-json-tree|react-base16-styling|lodash-es|rbush|quickselect|react-diff-viewer-continued|storybook/*.|json-stringify-pretty-compact|@x0k/json-schema-merge)', |
There was a problem hiding this comment.
Suggestion: The allowlist regex for @rjsf packages is malformed (@rjsf/*.), which is a typo in regex syntax and can fail to reliably match all @rjsf/* module paths for Babel transformation. Replace it with a proper scoped-package pattern (for example @rjsf/.*) so Jest consistently transpiles @rjsf ESM dependencies instead of intermittently throwing module parse errors. [typo]
Severity Level: Minor 🧹
- Warning: existing regex already matches @rjsf packages.
- Warning: suggestion targets stylistic pattern, not functional bug.Steps of Reproduction ✅
1. Open `superset-frontend/jest.config.js` and locate `transformIgnorePatterns` at lines
15–20 (as shown in the current file, with the long `node_modules/(?!...)` pattern at line
19).
2. Inspect the subpattern `@rjsf/*.` inside the negative lookahead at
`superset-frontend/jest.config.js:19`; this is the exact code added in this PR and
referenced in the suggestion.
3. Evaluate this subpattern as a JavaScript regular expression: `*` quantifies the
preceding `/`, so `@rjsf/*.` matches `@rjsf/` followed by zero or more `/` characters and
then at least one arbitrary character, which means paths like `@rjsf/core`, `@rjsf/utils`,
and `@rjsf/validator-ajv8` (actually used imports in
`superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx:21-23`) all match
this allowlist.
4. Because module paths under `node_modules/@rjsf/*` (e.g. `node_modules/@rjsf/core/...`)
satisfy this regex, Jest will still treat these packages as allowed for transformation;
there is no concrete scenario where this specific `@rjsf/*.` pattern fails to match while
`@rjsf/.*` would succeed, so the reported issue is effectively a stylistic preference
rather than a reproducible malfunction.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** superset-frontend/jest.config.js
**Line:** 78:78
**Comment:**
*Typo: The allowlist regex for `@rjsf` packages is malformed (`@rjsf/*.`), which is a typo in regex syntax and can fail to reliably match all `@rjsf/*` module paths for Babel transformation. Replace it with a proper scoped-package pattern (for example `@rjsf/.*`) so Jest consistently transpiles `@rjsf` ESM dependencies instead of intermittently throwing module parse errors.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fixThere was a problem hiding this comment.
The newly added dep to exclude from Jest code transform is a transitive dependency of @rjsf/* libraries so your comment doesn't make sense
1 participant
build(deps): update @rjsf deps to v6
SUMMARY
A bit of BAU to keep the project to currency. There are some changes to existing codebase but it's only for typing, pretty nil.
@rjsf/antd@rjsf/*deps to v6@babel/*or@rjsf/*, for better CI resource utilizationBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION