Skip to content

chore(table): drop dead th.ant-column-cell selector#42407

Merged
rusackas merged 1 commit into
masterfrom
fix/table-collection-header-ellipsis
Jul 26, 2026
Merged

chore(table): drop dead th.ant-column-cell selector#42407
rusackas merged 1 commit into
masterfrom
fix/table-collection-header-ellipsis

Conversation

@rusackas

@rusackas rusackas commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

SUMMARY

TableCollection styles th.ant-column-cell, but no such class exists (antd header cells are th.ant-table-cell), so the rule has never matched. Its intent is also already covered: the .ant-table-cell block in the same stylesheet applies ellipsis/nowrap truncation to header and body cells alike. Doubly dead, so this drops the block rather than renaming it.

Found while sweeping every ant-* class our Emotion styles reference against the set of classes antd v6 can actually emit; this was the only dead reference left after #42146 (it's dead in v5 too, so it's long-standing cruft rather than a migration regression).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual change; the removed rule never matched.

TESTING INSTRUCTIONS

Open any list view (e.g. Dashboards): long column headers still truncate with an ellipsis, exactly as before, via the .ant-table-cell rule.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

@dosubot dosubot Bot added change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. labels Jul 25, 2026
@bito-code-review

bito-code-review Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #724bc7

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 791cba7..791cba7
    • superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas @claude
chore(table): drop dead th.ant-column-cell selector
5b8107f 
th.ant-column-cell matches nothing antd renders, and header truncation
is already handled by the .ant-table-cell rule below (th and td both
carry that class), so the block was doubly dead. Remove it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@rusackas
rusackas force-pushed the fix/table-collection-header-ellipsis branch from 791cba7 to 5b8107f Compare July 25, 2026 03:03
@rusackas rusackas changed the title fix(table): apply header ellipsis to the real antd cell class chore(table): drop dead th.ant-column-cell selector Jul 25, 2026
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.24%. Comparing base (8c37d62) to head (5b8107f).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #42407   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files        2795     2795           
  Lines      157643   157643           
  Branches    36061    36061           
=======================================
  Hits       102853   102853           
  Misses      52814    52814           
  Partials     1976     1976
Flag Coverage Δ
javascript 71.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review

bito-code-review Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #89a331

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 5b8107f..5b8107f
    • superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas
rusackas merged commit 6c2ccc4 into master Jul 26, 2026
68 checks passed
@rusackas
rusackas deleted the fix/table-collection-header-ellipsis branch July 26, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hainenber hainenber hainenber approved these changes

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. packages preset-io size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rusackas @hainenber