fix(ci): make the Dependency Review check able to fail again - #42537
Merged
Conversation
continue-on-error: true on the dependency-review-action step meant neither fail-on-severity: critical nor the ASF licence denylist could stop a PR. The line arrived incidentally in apache#31961 (React 17 upgrade) with no stated reason.
kobihikri
requested review from
betodealmeida,
dpgaspar,
eschutho,
geido,
hainenber,
kgabryje,
mistercrunch,
nytai,
rusackas,
sadpandajoe,
sha174n and
villebro
as code owners
July 28, 2026 15:19
Contributor
|
Bito Automatic Review Skipped - Files Excluded |
hainenber
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
.github/workflows/dependency-review.ymlsetscontinue-on-error: trueon theactions/dependency-review-actionstep, so the step is reported as successful whatever the action finds, and thedependency-reviewjob passes either way.That step carries two policies:
fail-on-severity: critical— the vulnerability thresholddeny-licenses: MS-LPL, BUSL-1.1, QPL-1.0, Sleepycat, SSPL-1.0, CPOL-1.02, AGPL-3.0, GPL-1.0+, BSD-4-Clause-UC, NPL-1.0, NPL-1.1, JSON— which the comment directly above ties to https://www.apache.org/legal/resolved.htmlWith that flag in place, neither can stop a pull request. The file's own header comment says "if the workflow run is marked as required, PRs introducing known-vulnerable packages will be blocked from merging" — that is the behaviour the flag prevents.
I don't think it was deliberate. The line arrived in #31961 ("refactor: Upgrade to React 17"), whose description doesn't mention it, and there's no comment explaining it. My guess is it unblocked that one upgrade and then stayed. It's been there since January 2025.
This PR deletes that single line and changes nothing else.
TESTING INSTRUCTIONS
The change is one deletion in a workflow file, so the check on this PR is itself the test:
Dependency Reviewshould still run and pass here, since this PR adds no dependencies.To see the behaviour it restores, open a scratch PR adding a dependency under one of the denied licences (an
AGPL-3.0package, say). With the line removed the job fails; with it present the job succeeds and only prints a warning.One thing worth checking before merging: if
mastercurrently carries a dependency that tripsfail-on-severity: criticalor the licence denylist, this will start failing PRs until that is resolved. I could not verify that from outside the repo, so it seems worth a look — and if it does surface something, I'm glad to help with the follow-up.ADDITIONAL INFORMATION
To be clear about what this is: a CI configuration fix, not a security-vulnerability report. It makes no claim against the role and capability matrix in
SECURITY.mdand assumes no attacker principal, so per the automated-tooling requirements inAGENTS.mdI've raised it as an ordinary PR rather than as a finding. If you'd still rather have it as a question first, tell me and I'll move it.Disclosure: I used AI assistance to help spot this and draft the PR, and I verified the file, its history, and the surrounding behaviour myself.