You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Current date range frame received the selected value but did not pass it to Radio.GroupWrapper, leaving the radio group uncontrolled. This passes the value through so the selected Current option is shown and adds a regression test.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Reproduced on master and verified on this branch, using the same chart and the same steps. Only the branch differs.
Before
The Current option is already applied, as the actual time range shows, but no radio button is checked:
After
The radio button matching the current value is checked:
The same difference appears when the filter is reopened: on master, choosing Current day and applying it leaves every radio button unchecked once the filter is reopened, while here the corresponding radio button stays checked.
TESTING INSTRUCTIONS
Open a Date Range filter.
Select the Current frame and choose a value such as Current day.
Reopen the filter and verify the corresponding radio button remains selected.
Run: npm run test -- src/explore/components/controls/DateFilterControl/tests/CurrentCalendarFrame.test.tsx
Automated validation:
Focused Jest suite: 3 tests passed.
Pre-commit hooks for the changed files, including TypeScript type-checking: passed.
pre-commit run --all-files was executed; unrelated baseline/environment failures remain in main mypy checks, generated frontend declarations in the clean validation environment, and the unavailable helm-docs binary.
Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run. No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #42613.
The Current date range frame received the selected value but did not pass it to
Radio.GroupWrapper, leaving the radio group uncontrolled. This passes the value through so the selected Current option is shown and adds a regression test.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Reproduced on
masterand verified on this branch, using the same chart and the same steps. Only the branch differs.Before
The Current option is already applied, as the actual time range shows, but no radio button is checked:
After
The radio button matching the current value is checked:
The same difference appears when the filter is reopened: on
master, choosingCurrent dayand applying it leaves every radio button unchecked once the filter is reopened, while here the corresponding radio button stays checked.TESTING INSTRUCTIONS
npm run test -- src/explore/components/controls/DateFilterControl/tests/CurrentCalendarFrame.test.tsxAutomated validation:
pre-commit run --all-fileswas executed; unrelated baseline/environment failures remain in main mypy checks, generated frontend declarations in the clean validation environment, and the unavailablehelm-docsbinary.ADDITIONAL INFORMATION