fix(native-filters): allow X-clear on defaultToFirstItem filters with required warning

[madhushreeag]

SUMMARY

When "Select first filter value by default" is enabled, the filter value can now be cleared via the X button. Clearing shows the same red required-style validation warning as "Filter value is required", rather than silently re-auto-selecting the first item.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #95ff6e

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: e67e5b4..e67e5b4

  • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
  • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
  • superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.77%. Comparing base (7c03736) to head (e67e5b4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #42762   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files        2840     2840           
  Lines      161987   161995    +8     
  Branches    37124    37130    +6     
=======================================
+ Hits       106547   106555    +8     
  Misses      53375    53375           
  Partials     2065     2065           

Flag	Coverage Δ
javascript	72.01% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[villebro]

Awesome, this bug has been bugging people for as long as I can remember! 🙌 LGTM