fix(ci): restore master validation checks - #42807
Merged
Merged
Conversation
(cherry picked from commit 498e1876c584d66ca4e585d4307d9e6eca19d8a0)
(cherry picked from commit e98b88f6138135388187c13279c664f8e24a7e5e)
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #42807 +/- ##
==========================================
- Coverage 65.79% 65.79% -0.01%
==========================================
Files 2842 2842
Lines 162127 162125 -2
Branches 37158 37151 -7
==========================================
- Hits 106676 106667 -9
- Misses 53387 53393 +6
- Partials 2064 2065 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sadpandajoe
marked this pull request as ready for review
August 5, 2026 18:09
sadpandajoe
requested review from
eschutho,
geido,
mistercrunch and
rusackas
as code owners
August 5, 2026 18:09
rusackas
approved these changes
Aug 5, 2026
rusackas
left a comment
Member
There was a problem hiding this comment.
@sadpandajoe LGTM. Confirmed the 20 reformatted files are pure whitespace, oxfmt getting a full-tree pass makes sense. The relative-URL playwright fix and the frozen-clock MCP test are both solid, small fixes for what they're chasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Restore three deterministic checks found while walking master CI back to the last three-commit green boundary:
APP_ROOTin the version-history activity-log Playwright test by using the existingapiGethelper with relative URLs. The old leading-slash requests returned 404 in the required/app/prefixproject after feat(versioning): version-history UI #41551.The fixes remain three independent commits. They are consolidated because a required all-files pre-commit run from the affected master baseline necessarily includes the formatter rewrite.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; these are CI/test and formatting corrections with no UI behavior change.
TESTING INSTRUCTIONS
SKIP=type-checking-frontend pre-commit run --all-filesusing the workflow's Python 3.11/ruff 0.9.7 and Node 24.16/npm 11.13 toolchainoxfmt --checkacross all 3,769 frontend files after applying the formatter changesoxlint --config oxlint.json --quiet playwright/tests/version-history/activity-log.spec.tsplaywright test playwright/tests/version-history/activity-log.spec.ts --listhttp://127.0.0.1:8081/app/prefix/ruff format --check tests/unit_tests/mcp_service/common/test_time_range_validation.pyruff check tests/unit_tests/mcp_service/common/test_time_range_validation.pypython -m py_compile tests/unit_tests/mcp_service/common/test_time_range_validation.pyThe targeted MCP pytest could not run in the host environment because its globally installed sqlglot predates the
singlestoredialect imported by this checkout. Required GitHub checks use the repository's pinned dependencies and are monitored to terminal state.ADDITIONAL INFORMATION