Skip to content

fix(ci): restore master validation checks - #42807

Merged
rusackas merged 3 commits into
apache:masterfrom
sadpandajoe:codex/fix-master-ci-oxfmt
Aug 6, 2026
Merged

fix(ci): restore master validation checks#42807
rusackas merged 3 commits into
apache:masterfrom
sadpandajoe:codex/fix-master-ci-oxfmt

Conversation

@sadpandajoe

Copy link
Copy Markdown
Member

SUMMARY

Restore three deterministic checks found while walking master CI back to the last three-commit green boundary:

The fixes remain three independent commits. They are consolidated because a required all-files pre-commit run from the affected master baseline necessarily includes the formatter rewrite.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; these are CI/test and formatting corrections with no UI behavior change.

TESTING INSTRUCTIONS

  • SKIP=type-checking-frontend pre-commit run --all-files using the workflow's Python 3.11/ruff 0.9.7 and Node 24.16/npm 11.13 toolchain
  • oxfmt --check across all 3,769 frontend files after applying the formatter changes
  • oxlint --config oxlint.json --quiet playwright/tests/version-history/activity-log.spec.ts
  • playwright test playwright/tests/version-history/activity-log.spec.ts --list
  • Verify relative API URLs resolve below http://127.0.0.1:8081/app/prefix/
  • ruff format --check tests/unit_tests/mcp_service/common/test_time_range_validation.py
  • ruff check tests/unit_tests/mcp_service/common/test_time_range_validation.py
  • python -m py_compile tests/unit_tests/mcp_service/common/test_time_range_validation.py

The targeted MCP pytest could not run in the host environment because its globally installed sqlglot predates the singlestore dialect imported by this checkout. Required GitHub checks use the repository's pinned dependencies and are monitored to terminal state.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

(cherry picked from commit 498e1876c584d66ca4e585d4307d9e6eca19d8a0)
(cherry picked from commit e98b88f6138135388187c13279c664f8e24a7e5e)
@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 7e4a9bd
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a736e90a702ef00085f7068
😎 Deploy Preview https://deploy-preview-42807--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.23377% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.79%. Comparing base (816f37f) to head (7e4a9bd).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...onents/Datasource/FoldersEditor/TreeItem.styles.ts 25.00% 6 Missing ⚠️
...ages/superset-ui-core/src/components/Tabs/Tabs.tsx 0.00% 5 Missing ⚠️
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 33.33% 4 Missing ⚠️
...tend/plugins/plugin-chart-table/src/TableChart.tsx 76.92% 3 Missing ⚠️
...core/src/components/DynamicEditableTitle/index.tsx 60.00% 2 Missing ⚠️
...perset-ui-core/src/components/EmptyState/index.tsx 0.00% 2 Missing ⚠️
...plore/components/controls/VerticalRadioControl.tsx 0.00% 2 Missing ⚠️
...tiveFilters/FilterBar/CrossFilters/CrossFilter.tsx 75.00% 1 Missing ⚠️
...ativeFilters/FilterBar/UrlFilters/UrlFilterTag.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #42807      +/-   ##
==========================================
- Coverage   65.79%   65.79%   -0.01%     
==========================================
  Files        2842     2842              
  Lines      162127   162125       -2     
  Branches    37158    37151       -7     
==========================================
- Hits       106676   106667       -9     
- Misses      53387    53393       +6     
- Partials     2064     2065       +1     
Flag Coverage Δ
hive 38.07% <ø> (-0.01%) ⬇️
javascript 72.06% <66.23%> (-0.01%) ⬇️
mysql 57.90% <ø> (-0.01%) ⬇️
postgres 57.94% <ø> (-0.01%) ⬇️
presto 40.00% <ø> (-0.01%) ⬇️
python 59.32% <ø> (-0.01%) ⬇️
sqlite 57.57% <ø> (-0.01%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe
sadpandajoe marked this pull request as ready for review August 5, 2026 18:09

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadpandajoe LGTM. Confirmed the 20 reformatted files are pure whitespace, oxfmt getting a full-tree pass makes sense. The relative-URL playwright fix and the frozen-clock MCP test are both solid, small fixes for what they're chasing.

@rusackas rusackas added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Aug 5, 2026
@rusackas
rusackas merged commit b8c44a1 into apache:master Aug 6, 2026
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-if-green If approved and tests are green, please go ahead and merge it for me packages plugins size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants