Skip to content

style(frontend): apply oxfmt to existing files - #42813

Merged
richardfogaca merged 1 commit into
apache:masterfrom
mikebridge:chore/oxfmt-all-files
Aug 6, 2026
Merged

style(frontend): apply oxfmt to existing files#42813
richardfogaca merged 1 commit into
apache:masterfrom
mikebridge:chore/oxfmt-all-files

Conversation

@mikebridge

@mikebridge mikebridge commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

SUMMARY

Apply the repository-pinned oxfmt 0.61.0 formatter to 20 existing frontend files that drifted from its output. This restores a clean pre-commit run --all-files baseline. There are no behavioral or dependency changes.

It appears that the PR that transitioned from 0.60.0 to 0.61.0 but without running pre-commit with the new rules:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; formatting-only change.

TESTING INSTRUCTIONS

export PATH="$HOME/venv/superset/bin:$PATH"
cd superset-frontend && npm ci && cd ..
pre-commit run --all-files

All hooks pass, including oxfmt, oxlint, frontend type-checking, stylelint, MyPy, Ruff, and Pylint.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added the change:frontend Requires changing the frontend label Aug 5, 2026
@bito-code-review

bito-code-review Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #011fb5

Actionable Suggestions - 0
Review Details
  • Files reviewed - 20 · Commit Range: 4664949..4664949
    • superset-frontend/packages/superset-ui-core/src/components/DropdownButton/index.tsx
    • superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/index.tsx
    • superset-frontend/packages/superset-ui-core/src/components/EmptyState/index.tsx
    • superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
    • superset-frontend/packages/superset-ui-core/src/components/Tabs/Tabs.tsx
    • superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
    • superset-frontend/src/SqlLab/components/TableExploreTree/TreeNodeRenderer.tsx
    • superset-frontend/src/components/Datasource/FoldersEditor/TreeItem.styles.ts
    • superset-frontend/src/components/ListView/Filters/CompactSelectPanel.tsx
    • superset-frontend/src/dashboard/components/AutoRefreshStatus/StatusIndicatorDot.tsx
    • superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/CrossFilter.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/CrossFilterTag.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/CrossFilterTitle.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/UrlFilters/UrlFilterTag.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
    • superset-frontend/src/explore/components/controls/VerticalRadioControl.tsx
    • superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx
    • superset-frontend/src/features/home/RightMenu.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@bito-code-review

Copy link
Copy Markdown
Contributor

The flagged issue regarding the abrupt transition when switching from an active to an inactive tile is correct. When the transition property is set to none based on the active state, it prevents the browser from animating the width change, causing an abrupt layout shift.

To resolve this, you should ensure the transition property remains enabled or is applied independently of the active state. For example, you can move the transition property outside of the conditional block that toggles based on the active state, or ensure it is always present on the element.

Since the file superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx is not present in the provided PR diff, I cannot implement the fix directly. Please verify the file path and ensure the relevant code is included in the PR.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.23377% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.75%. Comparing base (0e4e368) to head (4664949).

Files with missing lines Patch % Lines
...onents/Datasource/FoldersEditor/TreeItem.styles.ts 25.00% 6 Missing ⚠️
...ages/superset-ui-core/src/components/Tabs/Tabs.tsx 0.00% 5 Missing ⚠️
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 33.33% 4 Missing ⚠️
...tend/plugins/plugin-chart-table/src/TableChart.tsx 76.92% 3 Missing ⚠️
...core/src/components/DynamicEditableTitle/index.tsx 60.00% 2 Missing ⚠️
...perset-ui-core/src/components/EmptyState/index.tsx 0.00% 2 Missing ⚠️
...plore/components/controls/VerticalRadioControl.tsx 0.00% 2 Missing ⚠️
...tiveFilters/FilterBar/CrossFilters/CrossFilter.tsx 75.00% 1 Missing ⚠️
...ativeFilters/FilterBar/UrlFilters/UrlFilterTag.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #42813      +/-   ##
==========================================
- Coverage   65.75%   65.75%   -0.01%     
==========================================
  Files        2842     2842              
  Lines      162277   162269       -8     
  Branches    37173    37165       -8     
==========================================
- Hits       106711   106698      -13     
- Misses      53498    53503       +5     
  Partials     2068     2068              
Flag Coverage Δ
javascript 72.06% <66.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardfogaca
richardfogaca merged commit a00e295 into apache:master Aug 6, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants