Skip to content

feat(hooks): add configurable post-creation hook for dashboards - #42837

Merged
alexandrusoare merged 5 commits into
masterfrom
alexandrusoare/feat/after-asset-create-hook
Aug 6, 2026
Merged

feat(hooks): add configurable post-creation hook for dashboards#42837
alexandrusoare merged 5 commits into
masterfrom
alexandrusoare/feat/after-asset-create-hook

Conversation

@alexandrusoare

Copy link
Copy Markdown
Contributor

SUMMARY

Adds an AFTER_ASSET_CREATE config callback that fires after a new dashboard is persisted. This allows downstream integrations (e.g. auto-categorization, audit logging, notification triggers) to react to asset creation without modifying core views. The hook receives the model instance and the asset type string ("dashboard").

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added change:backend Requires changing the backend dashboard Namespace | Anything related to the Dashboard labels Aug 6, 2026
@bito-code-review

bito-code-review Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #19df46

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 22eb37d..1f992d7
    • superset/views/dashboard/views.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.73%. Comparing base (0fc0d21) to head (922c5cd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #42837   +/-   ##
=======================================
  Coverage   65.73%   65.73%           
=======================================
  Files        2843     2843           
  Lines      162653   162656    +3     
  Branches    37239    37240    +1     
=======================================
+ Hits       106912   106914    +2     
- Misses      53648    53649    +1     
  Partials     2093     2093           
Flag Coverage Δ
hive 37.95% <25.00%> (-0.01%) ⬇️
mysql 57.79% <100.00%> (+<0.01%) ⬆️
postgres 57.83% <100.00%> (+<0.01%) ⬆️
presto 39.86% <25.00%> (-0.01%) ⬇️
python 59.20% <100.00%> (+<0.01%) ⬆️
sqlite 57.47% <100.00%> (+<0.01%) ⬆️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 6, 2026
@alexandrusoare
alexandrusoare merged commit 57d6e5c into master Aug 6, 2026
75 checks passed
@alexandrusoare
alexandrusoare deleted the alexandrusoare/feat/after-asset-create-hook branch August 6, 2026 13:11
@bito-code-review

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:backend Requires changing the backend dashboard Namespace | Anything related to the Dashboard size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants