fix(country-map): Malawi map - add missing Karonga district, de-duplicate Chitipa - #42842
Open
denys1204 wants to merge 1 commit into
Open
fix(country-map): Malawi map - add missing Karonga district, de-duplicate Chitipa#42842denys1204 wants to merge 1 commit into
denys1204 wants to merge 1 commit into
Conversation
…cate Chitipa Signed-off-by: Denys Mamchura <denys.work.ua@gmail.com>
Contributor
|
Bito Review Skipped - No Changes Detected |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The bundled Malawi map in
legacy-plugin-chart-country-mapis missing the Karonga district (MW-KR) and has Chitipa (MW-CT) duplicated, so Karonga always renders blank on the Malawi Country Map regardless of the data.malawi.geojsonhas 28 features but only 27 unique ISO codes:MW-CTappears twice andMW-KRis absent. Malawi has 28 districts and ISO 3166-2:MW includesMW-KR(Karonga), so one of the twoMW-CTfeatures is mislabeled.Of the two
{ "ISO": "MW-CT", "NAME_1": "Chitipa" }features, the eastern polygon is geographically Karonga, not Chitipa:The fix relabels that one polygon's properties and leaves the geometry untouched:
{ "ISO": "MW-CT", "NAME_1": "Chitipa" }becomes{ "ISO": "MW-KR", "NAME_1": "Karonga" }.It's a one-line label correction on existing data, with no new geometry and no licensing change. All 28 districts now have unique ISO codes, and Karonga renders.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Malawi Country Map: Karonga is blank before the fix, shaded after.
TESTING INSTRUCTIONS
Render any chart with
viz_type: country_mapandselect_country: malawi. Karonga (far north, on the lakeshore) is now shaded instead of blank, and no district is duplicated.ADDITIONAL INFORMATION