fix(helm): add missing task modules to default CeleryConfig imports - #42945
Conversation
The default Celery config generated by the Helm chart only imported superset.tasks.scheduler, superset.tasks.thumbnails and superset.tasks.cache alongside superset.sql_lab, leaving out superset.tasks.slack. Without this import, Helm-deployed Celery workers never register the Slack report/alert delivery tasks, so alerts and reports configured to notify Slack silently fail to send. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review Agent Run #d4c8c4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
…x-helm-remove-unu
|
Bito Automatic Review Skipped – PR Already Merged |
Follow-up to #37259. That PR removed the unused
SQLALCHEMY_TRACK_MODIFICATIONSsetting from the Helm chart's default Celery/config block. While in that area, I noticed the chart's built-in defaultCeleryConfig.importstuple (used whencache.enabledis true and no customconfig.celeryConfigis supplied) is missingsuperset.tasks.slack, even thoughsuperset/config.py's own defaultCELERY_CONFIG.importsincludes it alongsidescheduler,thumbnails, andcache(which the chart already had).SUMMARY
Add
superset.tasks.slackto the defaultCeleryConfig.importstuple rendered by the Helm chart's_helpers.tpl. Without it, Celery workers deployed via this chart's default config never register the Slack task module, so alerts/reports configured to notify Slack silently fail to send.Also bumps the chart's patch version (0.22.4 -> 0.22.5) per this chart's versioning convention, and regenerates
README.mdviahelm-docsaccordingly.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (Helm template change)
TESTING INSTRUCTIONS
cache.enabled: trueand noconfig.celeryConfigoverride.superset_config.py'sCeleryConfig.importstuple includes"superset.tasks.slack"alongside the existing entries.helm unittest helm/supersetpasses locally (105/105 tests).ADDITIONAL INFORMATION
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com