fix(frontend): remove any type and duplicate route in routes.tsx - #43014
Merged
sadpandajoe merged 1 commit intoAug 10, 2026
Merged
Conversation
Follow-up to #41205. That PR widened the routes Component/Fallback type to ComponentType<any>, violating the no-any policy, and introduced a duplicate REGISTRATIONS route (once unconditionally in the base routes array, once gated behind authRegistrationEnabled). Restore the narrower ComponentType generics and drop the redundant unconditional entry so the route is only registered when user registration is enabled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Code Review Agent Run #417390Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
sadpandajoe
approved these changes
Aug 10, 2026
sadpandajoe
deleted the
fix/followup-41205-follow-up-from-41205-feat-extensions-add
branch
August 10, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #41205.
SUMMARY
That PR widened the
Routestype insuperset-frontend/src/views/routes.tsxfromComponentTypetoComponentType<any>, which violates the project's no-anypolicy, and it leftRoutePaths.REGISTRATIONSregistered twice: once unconditionally in the baseroutesarray and again gated behindauthRegistrationEnabled. This PR restores the narrowerComponentTypegeneric and removes the redundant unconditional entry so the registrations route is only registered when user self-registration is enabled.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - no UI change.
TESTING INSTRUCTIONS
superset-frontend/src/views/routes.tsxno longer has a duplicateRoutePaths.REGISTRATIONSentry.AUTH_USER_REGISTRATIONdisabled,/registrations/is no longer registered as a frontend route.AUTH_USER_REGISTRATIONenabled,/registrations/still routes toUserRegistrationsas before.ADDITIONAL INFORMATION