fix(ci): update vulnerable transitive nanoid - #43166
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43166 +/- ##
=======================================
Coverage 66.69% 66.69%
=======================================
Files 2872 2872
Lines 163452 163452
Branches 37725 37725
=======================================
Hits 109022 109022
Misses 52302 52302
Partials 2128 2128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Pins vulnerable transitive nanoid v3 dependencies in the Superset frontend to 3.3.18 via an npm override, ensuring Dependabot/security tooling can resolve the active advisories while keeping the direct nanoid@6 dependency unchanged.
Changes:
- Add an npm
overridesrule to forcenanoid@>=3 <4to3.3.18. - Refresh
package-lock.jsonso the two affected transitive installs (postcssandreact-checkbox-tree) resolve to3.3.18.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| superset-frontend/package.json | Adds an npm override to pin transitive nanoid v3 to 3.3.18. |
| superset-frontend/package-lock.json | Updates the two nested nanoid v3 lockfile entries to 3.3.18 while leaving the direct nanoid@6.0.1 intact. |
Files not reviewed (1)
- superset-frontend/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SUMMARY
Pin transitive Nanoid v3 dependencies to 3.3.18, the lowest release that resolves both active advisories, and refresh the two affected lockfile entries.
Dependabot's security updater could not raise the existing 3.3.12 and 3.3.16 transitive copies even though their parent ranges admit 3.3.18. The major-scoped npm override keeps Nanoid v1/v2 compatible and leaves the direct Nanoid v6 dependency unchanged.
This repairs the deterministic
security_update_not_possiblefailure from Dependabot run 31788627845.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; dependency-only change.
TESTING INSTRUCTIONS
From
superset-frontendwith Node 24.16.0 and npm 11.13.0:Expected Nanoid tree: direct 6.0.1; PostCSS and react-checkbox-tree transitive copies both 3.3.18.
Also verified:
npm audit --jsoncontains no Nanoid advisory (the command still reports unrelated existing advisories).npm run stylelintpre-commit runon the changed filespre-commit run --all-fileswas executed; repository-wide baseline/tooling failures are unrelated to this two-file change (formatter/Ruff drift, missing localyarn/helm-docs, and unbuilt TypeScript project references).ADDITIONAL INFORMATION