docs(embedding): document EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITE - #43600
Conversation
Follow-up to #39925, which added the config flag but didn't document it. Explains the default permalink-origin rewrite behavior for proxied/ subdirectory deployments and how to opt out. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
doc
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #e1a36c
Actionable Suggestions - 1
-
docs/docs/using-superset/embedding.mdx - 1
- Doc misrepresents rewrite scope · Line 93-93
Review Details
-
Files reviewed - 1 · Commit Range:
0940655..0940655- docs/docs/using-superset/embedding.mdx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers an incremental AI Review. -
/review full- Manually triggers a full AI Review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bito Automatic Review Skipped – PR Already Merged |
2 participants
SUMMARY
#39925 added the
EMBEDDED_DISABLE_PERMALINK_ORIGIN_REWRITEconfig flag (opt-out for the frontend's permalink origin rewrite, used to avoid handing out unreachable internal-host permalinks on proxied/subdirectory deployments) but never documented it. This adds a short section to the embedding docs, next to the existingresolvePermalinkUrlcallback docs since both deal with permalink URLs in embedded contexts.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, docs only.
TESTING INSTRUCTIONS
docs/docs/using-superset/embedding.mdxand confirm the new "Permalink origin rewriting" section accurately describes the flag added in refactor(frontend): centralize subdirectory URL prefixing behind nav helpers #39925 (superset/config.py,superset/views/base.py,superset-frontend/src/utils/urlUtils.ts).ADDITIONAL INFORMATION