fix(ui): preserve default modal resize handles when config is partial by deepujain · Pull Request #43806 · apache/superset

deepujain · 2026-09-02T19:54:03Z

SUMMARY

Drill to detail, Drill by, and View as table modals pass a partial resizableConfig (min size and default height only). Modal replaced the full default config with that partial object, which dropped the enable map that restricts resize handles to bottom, bottom-right, and right.

With all handles enabled inside a draggable wrapper, resizing from top or left edges drifts and anchors from the wrong corner (#43320).

This change merges caller overrides with the default resizable config so handle guards stay in place unless explicitly overridden.

TESTING INSTRUCTIONS

npm test -- --testPathPattern=packages/superset-ui-core/src/components/Modal/Modal.test.tsx
Manual: open Drill to detail or Drill by, confirm only bottom/right resize handles appear and resizing does not drift.

ADDITIONAL INFORMATION

Fixes #43320

bito-code-review · 2026-09-02T19:54:14Z

Code Review Agent Run #249c7e

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx - 1
- enable:false dropped in merge · Line 248-251
  
  `ResizableProps.enable` is typed `Enable | false`, so a caller can pass `enable: false` to disable all handles. The spread `{...defaults.enable, ...overrides.enable}` treats `false` as a no-op (spreading a boolean yields `{}`), silently keeping the default handles. The prior code passed `resizableConfig` through unchanged, so this is a regression. Guard the `false` case explicitly.

Review Details

Files reviewed - 2 · Commit Range: 753a9c3..753a9c3
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

Copilot

🟢 Approval recommended

The change is scoped, matches the stated issue/root cause, and includes focused unit tests covering the new merge behavior.

Pull request overview

Fixes resizable/draggable modal “drift” by ensuring callers that pass a partial resizableConfig don’t accidentally discard the default resize-handle enable guards in the shared Modal component.

Changes:

Add mergeResizableConfig() helper to merge caller resizableConfig overrides with defaultResizableConfig, preserving default resize-handle restrictions unless explicitly overridden.
Update Modal to use the merged config via useMemo.
Add unit tests validating default-handle preservation and explicit enable overrides.

File summaries

File	Description
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx	Merges default resizable settings with caller overrides to preserve resize-handle guards in draggable modals.
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx	Adds targeted tests for the new merge behavior to prevent regressions.

Review details

Files reviewed: 2/2 changed files
Comments generated: 1
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

bito-code-review · 2026-09-03T01:22:08Z

Adding an explicit return type to mergeResizableConfig is a recommended practice for exported functions in TypeScript modules. It ensures the public API surface remains stable and prevents accidental breaking changes if the internal implementation or the return type of defaultResizableConfig evolves.

To implement this, you can import the ResizableProps or ModalProps type (depending on your project's type definitions) and use it as the return type annotation:

export function mergeResizableConfig(
  hideFooter: boolean | undefined,
  overrides: ModalProps['resizableConfig'] = {},
): ModalProps['resizableConfig'] {
  const defaults = defaultResizableConfig(hideFooter);
  // ... implementation
}

superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx

export function mergeResizableConfig(
  hideFooter: boolean | undefined,
  overrides: ModalProps['resizableConfig'] = {},
): ModalProps['resizableConfig'] {
  const defaults = defaultResizableConfig(hideFooter);
  if (!overrides || Object.keys(overrides).length === 0) {
    return defaults;
  }
  return {
    ...defaults,
    ...overrides,
    enable: {
      ...defaults.enable,
      ...overrides.enable,
    },
  };
}

bito-code-review · 2026-09-03T09:28:26Z

Code Review Agent Run #81ab04

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 6bdc758..a708e0c
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-09-03T12:42:35Z

Code Review Agent Run #5bdff6

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 6a92dd2..8159ee0
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-09-03T16:22:26Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.46%. Comparing base (d9b201d) to head (339fc44).

Files with missing lines	Patch %	Lines
...es/superset-ui-core/src/components/Modal/Modal.tsx	91.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #43806   +/-   ##
=======================================
  Coverage   79.45%   79.46%           
=======================================
  Files        2895     2895           
  Lines      168167   168175    +8     
  Branches    38995    38999    +4     
=======================================
+ Hits       133624   133633    +9     
+ Misses      32044    32043    -1     
  Partials     2499     2499

Flag	Coverage Δ
javascript	`75.01% <91.66%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

deepujain · 2026-09-03T20:23:48Z

Fixed the current frontend type-check failure by making mergeResizableConfig return its actual non-nullable contract.

Validated on the pushed change:

npm test -- packages/superset-ui-core/src/components/Modal/Modal.test.tsx (9 tests passed)
npx oxlint --config oxlint.json --quiet packages/superset-ui-core/src/components/Modal/Modal.tsx packages/superset-ui-core/src/components/Modal/Modal.test.tsx
npm run plugins:build && npm run type

bito-code-review · 2026-09-03T21:02:21Z

Code Review Agent Run #7e9f9b

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 39bfdfe..cb209a8
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-09-04T05:20:23Z

Code Review Agent Run #c9bc85

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx - 1
- enable:true override dropped · Line 249-255
  
  `mergeResizableConfig` drops an explicit `enable: true`: `typeof true === 'object'` is false, so it falls to `{}` and returns the restricted `defaults.enable` (top/left/topLeft/topRight/bottomLeft all false). re-resizable's `Enable` type accepts a boolean (the repo's own test uses `enable: false`), so `enable: true` should enable all handles. No current caller passes it, but this is a latent gap in the new exported API.

Review Details

Files reviewed - 2 · Commit Range: 5c58d12..53803d0
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

Drill and chart modals pass only min/defaultSize in resizableConfig, which dropped the default enable map and exposed all handles, causing drift from non-bottom-right corners. Merge overrides with defaults instead. Fixes apache#43320

Guard ResizableProps.enable === false so partial merges do not silently re-enable default handles. Add regression test and explicit return type. Signed-off-by: Deepak Jain <deepujain@gmail.com>

The helper always returns a concrete config, so expose that contract to keep strict TypeScript checks from treating test and caller dereferences as optional. Signed-off-by: Deepak Jain <deepujain@gmail.com>

deepujain · 2026-09-04T16:23:50Z

The latest Bito additional suggestion about enable: true is not applicable to the current contract. ResizableProps['enable'] accepts Enable | false, and npm run type rejects true with TS2322. I left the implementation unchanged, rebased onto current master, and revalidated the 9 focused tests, changed-file oxlint, package declarations, and root type check.

sadpandajoe · 2026-09-04T16:43:22Z


 const isDragged = () => !!document.querySelector('.react-draggable-dragged');

+describe('mergeResizableConfig', () => {


These tests only call the extracted helper, so they still pass if CustomModal stops passing the merged configuration to Resizable; partial callers would then regain the guarded top/left handles. Could this render Modal with the partial caller config and assert the rendered handle set?

bito-code-review · 2026-09-04T19:28:25Z

Code Review Agent Run #c2cd37

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: a911da3..339fc44
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size Bot added the size/M label Sep 2, 2026

github-actions Bot added the packages label Sep 2, 2026

sadpandajoe requested review from rusackas and sadpandajoe and a lite review from Copilot September 3, 2026 01:17

Copilot started reviewing on behalf of sadpandajoe September 3, 2026 01:18 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx Outdated

sadpandajoe reviewed Sep 3, 2026

View reviewed changes

Comment thread superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx Outdated

deepujain force-pushed the fix-43320-resizable-modal-handles branch from 753a9c3 to 6bdc758 Compare September 3, 2026 06:22

deepujain force-pushed the fix-43320-resizable-modal-handles branch from a708e0c to 8159ee0 Compare September 3, 2026 09:40

deepujain force-pushed the fix-43320-resizable-modal-handles branch 2 times, most recently from a4c36bb to f820ab1 Compare September 3, 2026 19:29

deepujain force-pushed the fix-43320-resizable-modal-handles branch from 49d9671 to cb209a8 Compare September 3, 2026 20:50

deepujain force-pushed the fix-43320-resizable-modal-handles branch from cb209a8 to 53803d0 Compare September 4, 2026 02:18

deepujain added 3 commits September 4, 2026 09:21

fix(ui): preserve enable: false in mergeResizableConfig

01732f1

Guard ResizableProps.enable === false so partial merges do not silently re-enable default handles. Add regression test and explicit return type. Signed-off-by: Deepak Jain <deepujain@gmail.com>

fix(ui): make merged resize config non-nullable

339fc44

The helper always returns a concrete config, so expose that contract to keep strict TypeScript checks from treating test and caller dereferences as optional. Signed-off-by: Deepak Jain <deepujain@gmail.com>

deepujain force-pushed the fix-43320-resizable-modal-handles branch from 53803d0 to 339fc44 Compare September 4, 2026 16:23

sadpandajoe reviewed Sep 4, 2026

View reviewed changes


		const isDragged = () => !!document.querySelector('.react-draggable-dragged');

		describe('mergeResizableConfig', () => {

Uh oh!

Conversation

deepujain commented Sep 2, 2026

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #249c7e

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

bito-code-review Bot commented Sep 3, 2026

Uh oh!

Uh oh!

bito-code-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #81ab04

Uh oh!

bito-code-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #5bdff6

Uh oh!

codecov Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

deepujain commented Sep 3, 2026

Uh oh!

bito-code-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #7e9f9b

Uh oh!

bito-code-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c9bc85

Uh oh!

deepujain commented Sep 4, 2026

Uh oh!

sadpandajoe Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c2cd37

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bito-code-review Bot commented Sep 2, 2026 •

edited

Loading

bito-code-review Bot commented Sep 3, 2026 •

edited

Loading

bito-code-review Bot commented Sep 3, 2026 •

edited

Loading

codecov Bot commented Sep 3, 2026 •

edited

Loading

bito-code-review Bot commented Sep 3, 2026 •

edited

Loading

bito-code-review Bot commented Sep 4, 2026 •

edited

Loading

bito-code-review Bot commented Sep 4, 2026 •

edited

Loading