fix(i18n): improve Simplified Chinese translations - #43813
Conversation
Code Review Agent Run #7c80d1Actionable Suggestions - 0Additional Suggestions - 8
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
i18n
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
| RUN /app/docker/apt-install.sh \ | ||
| build-essential \ | ||
| pkg-config \ | ||
| default-libmysqlclient-dev |
There was a problem hiding this comment.
Suggestion: The lean image keeps the compiler and development packages because pip-install.sh sees build-essential as preinstalled and does not remove them, bloating the runtime image. [performance]
Assessment: 🟠 Major · 🔁 Occurrence: Often
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** Dockerfile
**Line:** 234:237
**Comment:**
*Performance: The lean image keeps the compiler and development packages because `pip-install.sh` sees `build-essential` as preinstalled and does not remove them, bloating the runtime image.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
The suggestion to remove build-essential and development packages from the lean Docker image is correct. These packages are only required during the build phase to compile dependencies like To resolve this, you should use a multi-stage Docker build. In the first stage (builder), install the necessary build tools and compile the dependencies. In the second stage (runtime), copy only the necessary artifacts (like the installed Python packages) from the builder stage, ensuring that the build tools are not included. Would you like me to fetch all the comments and validate the rest of the PR to implement a comprehensive fix? |
8b80250 to
0813388
Compare
github-actions
Bot
removed
doc
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43813 +/- ##
==========================================
- Coverage 79.42% 79.40% -0.02%
==========================================
Files 2895 2892 -3
Lines 167947 167821 -126
Branches 38896 38782 -114
==========================================
- Hits 133386 133259 -127
- Misses 32061 32062 +1
Partials 2500 2500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the review. I addressed the translation-related suggestions in commit
The PR still contains only |
Code Review Agent Run #982abfActionable Suggestions - 0Additional Suggestions - 4
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
- Remove stale fuzzy flag on 'Upload Columnar' - Translate 'other' in database selection message - Use '偏移开始日期' for consistency with '时间偏移' - Remove leftover machine-translation marker on 'How many top values to select'
Code Review Agent Run #923d8cActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
| "These %(type)s will be moved to Recently Archived. You can recover them " | ||
| "there within %(days)s days." | ||
| msgstr "" | ||
| msgstr "这些 %(type)s 将被移至“最近归档”。您可以在 %(days)s 天内从那里恢复它们。" |
There was a problem hiding this comment.
These strings no longer match the runtime IDs—the caller includes in the Settings menu, and the POT contains only that version—so filling them leaves Chinese users on the fallback text. Could the translations be moved to the active four IDs?
The previous translations sat on stale msgids that no longer exist in the POT - the runtime IDs include 'in the Settings menu'. Move the four translated entries (two plural, two singular) onto the active IDs so Chinese users actually see the translated copy.
2 participants
SUMMARY
Improve Simplified Chinese translations in
messages.poby fixing untranslated English fragments, incorrect terminology, and awkward UI messages across chart configuration, archive/recovery workflows, SQL Lab, and validation errors.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable: translation-only change.
TESTING INSTRUCTIONS
Review the updated entries in
superset/translations/zh/LC_MESSAGES/messages.po.Run the translation catalog validation/build checks in the normal CI workflow.
ADDITIONAL INFORMATION