fix(dashboard): prevent header metadata bar from overlapping action buttons at narrow widths - #43845
Draft
sadpandajoe wants to merge 1 commit into
Draft
fix(dashboard): prevent header metadata bar from overlapping action buttons at narrow widths#43845sadpandajoe wants to merge 1 commit into
sadpandajoe wants to merge 1 commit into
Conversation
…ns menu On the dashboard page header, narrowing the browser window shrinks the editable title down to nothing, but the certification/fave-star badges and metadata bar (last modified / owner info) had no way to shrink or clip. Once the title fully collapsed, that cluster rendered outside its allotted flex space and visually overlapped the kebab-menu/action buttons instead of collapsing. Add overflow: hidden to the title panel's badges/metadata-bar wrapper so it clips along with the title as space runs out. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43845 +/- ##
==========================================
- Coverage 79.42% 79.42% -0.01%
==========================================
Files 2895 2895
Lines 167947 167947
Branches 38896 38896
==========================================
- Hits 133388 133385 -3
- Misses 32059 32062 +3
Partials 2500 2500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a layout bug on the dashboard page header: at narrow browser widths, the header's metadata cluster (last-modified and owner/editor info, next to the certified/favorite/published badges) has no overflow protection. Once the dashboard title fully collapses via its own ellipsis behavior, further narrowing causes that metadata cluster to render past its allotted flex space and visually overlap the header's Edit/kebab-menu buttons instead of being clipped.
Root cause:
buttonsStylesinPageHeaderWithActions(the flex wrapper around the certified badge, fave star, and metadata bar inside.title-panel) had noflex-shrink:0/overflow:hidden, so once its sibling (the title) shrank to its own minimum, the browser let this cluster's content render outside its box rather than clipping it.Fix: add
overflow: hiddentobuttonsStylesso the cluster clips within its allotted space instead of overlapping neighboring header content.This is a customer-reported issue affecting narrow desktop browser widths (not a mobile-specific problem).
BEFORE
At ~420px header width, the metadata info overlaps the Edit/kebab-menu buttons and the title is fully truncated:
AFTER
At the same width, the title truncates with an ellipsis as expected, and the buttons remain cleanly separated from any metadata content:
TESTING INSTRUCTIONS
npm run playwright:storybook— new real-browser (Chromium) spec sweeps header width and asserts no bounding-box intersection between the metadata bar and the right-side action buttons; RED before this fix, GREEN after.npm run test -- PageHeaderWithActions— jsdom regression test guarding the added CSS property.ADDITIONAL INFORMATION