Skip to content

fix(dashboard): prevent header metadata bar from overlapping action buttons at narrow widths - #43845

Draft
sadpandajoe wants to merge 1 commit into
masterfrom
fix-dashboard-header-metadata-bar-overlap
Draft

fix(dashboard): prevent header metadata bar from overlapping action buttons at narrow widths#43845
sadpandajoe wants to merge 1 commit into
masterfrom
fix-dashboard-header-metadata-bar-overlap

Conversation

@sadpandajoe

Copy link
Copy Markdown
Member

SUMMARY

Fixes a layout bug on the dashboard page header: at narrow browser widths, the header's metadata cluster (last-modified and owner/editor info, next to the certified/favorite/published badges) has no overflow protection. Once the dashboard title fully collapses via its own ellipsis behavior, further narrowing causes that metadata cluster to render past its allotted flex space and visually overlap the header's Edit/kebab-menu buttons instead of being clipped.

Root cause: buttonsStyles in PageHeaderWithActions (the flex wrapper around the certified badge, fave star, and metadata bar inside .title-panel) had no flex-shrink:0/overflow:hidden, so once its sibling (the title) shrank to its own minimum, the browser let this cluster's content render outside its box rather than clipping it.

Fix: add overflow: hidden to buttonsStyles so the cluster clips within its allotted space instead of overlapping neighboring header content.

This is a customer-reported issue affecting narrow desktop browser widths (not a mobile-specific problem).

BEFORE

At ~420px header width, the metadata info overlaps the Edit/kebab-menu buttons and the title is fully truncated:

before

AFTER

At the same width, the title truncates with an ellipsis as expected, and the buttons remain cleanly separated from any metadata content:

after

TESTING INSTRUCTIONS

  • npm run playwright:storybook — new real-browser (Chromium) spec sweeps header width and asserts no bounding-box intersection between the metadata bar and the right-side action buttons; RED before this fix, GREEN after.
  • npm run test -- PageHeaderWithActions — jsdom regression test guarding the added CSS property.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…ns menu

On the dashboard page header, narrowing the browser window shrinks the
editable title down to nothing, but the certification/fave-star badges and
metadata bar (last modified / owner info) had no way to shrink or clip. Once
the title fully collapsed, that cluster rendered outside its allotted flex
space and visually overlapped the kebab-menu/action buttons instead of
collapsing.

Add overflow: hidden to the title panel's badges/metadata-bar wrapper so it
clips along with the title as space runs out.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (3258f5f) to head (cafb9b6).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #43845      +/-   ##
==========================================
- Coverage   79.42%   79.42%   -0.01%     
==========================================
  Files        2895     2895              
  Lines      167947   167947              
  Branches    38896    38896              
==========================================
- Hits       133388   133385       -3     
- Misses      32059    32062       +3     
  Partials     2500     2500              
Flag Coverage Δ
javascript 74.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe sadpandajoe added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Sep 4, 2026
@github-actions github-actions Bot added 🎪 cafb9b6 🚦 building 🎪 cafb9b6 🤡 sadpandajoe Environment cafb9b6 requested by sadpandajoe 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎪 Showtime is building environment on GHA for cafb9b6

@github-actions github-actions Bot added 🎪 cafb9b6 🚦 deploying 🎪 cafb9b6 🚦 failed Environment cafb9b6 status: failed 🎪 cafb9b6 📅 2026-09-04T05-25 Environment cafb9b6 created at 2026-09-04T05-25 🎪 cafb9b6 🤡 sadpandajoe Environment cafb9b6 requested by sadpandajoe and removed 🎪 cafb9b6 🚦 building 🎪 cafb9b6 🚦 failed Environment cafb9b6 status: failed 🎪 cafb9b6 🤡 sadpandajoe Environment cafb9b6 requested by sadpandajoe labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎪 Showtime is building environment on GHA for cafb9b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎪 cafb9b6 🚦 failed Environment cafb9b6 status: failed 🎪 cafb9b6 🤡 sadpandajoe Environment cafb9b6 requested by sadpandajoe 🎪 cafb9b6 📅 2026-09-04T05-25 Environment cafb9b6 created at 2026-09-04T05-25 dependencies:npm packages size/L 🎪 ⌛ 48h Environment expires after 48 hours (default)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant