test(treemap): pin border-free labels so tiles render without seams

[rusackas]

SUMMARY

Regression test for the Treemap "vertical line inside every tile" symptom reported in #43862.

The line came from a 1px borderColor/borderWidth on the label style. ECharts sizes the label's text box to the full node height (via the treemap view's beforeUpdate hook), so the box border rendered as a vertical line right after the label text, spanning the whole tile. #37808 removed the border and the symptom is gone on master (the reporter's screenshot also shows the inter-node gaps that #40181 removed, so their build predates both fixes; the border was still present in the 6.0.0 release).

Nothing pinned that fix, so this adds a test that walks every label / upperLabel style in the transformed options (series, emphasis, levels, upper labels, and the filtered-node label) and asserts none of them declares a border. Verified the test fails if the old borderColor/borderWidth pair is reintroduced on labelProps, and passes on master.

Rendered the pre-#37808 options with both ECharts 5.6.0 and 6.1.0 to confirm the mechanism; both draw the same line the reporter sees:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A, test-only.

TESTING INSTRUCTIONS

cd superset-frontend
npx jest --runInBand plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts

To see it fail, add borderColor: theme.colorBgBase, borderWidth: 1 back to labelProps in src/Treemap/transformProps.ts.

ADDITIONAL INFORMATION

• Has associated issue: Unexpected vertical white lines inside Treemap tiles #43862 (already fixed on master by fix: Vertical lines in the middle of Treemap categories #37808; this pins it)
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

https://claude.ai/code/session_015XdpWLXhUs7r8d4F2R5D6F

[bito-code-review]

Code Review Agent Run #d6d129

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: b0c8c7b..b0c8c7b

  • superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers an incremental AI Review.

• /review full - Manually triggers a full AI Review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.45%. Comparing base (e1ce6b6) to head (b0c8c7b).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #43890   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files        2895     2895           
  Lines      168167   168167           
  Branches    38995    38995           
=======================================
+ Hits       133616   133623    +7     
+ Misses      32052    32045    -7     
  Partials     2499     2499           

Flag	Coverage Δ
javascript	75.01% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SBIN2010]

Thanks @rusackas , that's a good addition.