[SYSTEMDS-3272] applySchema.dml() builtin #1732
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a to a given frame
Baunsgaard
reviewed
Nov 16, 2022
Contributor
Baunsgaard
left a comment
Baunsgaard
left a comment
There was a problem hiding this comment.
Close but not quite there yet.
| schema[i] = Types.ValueType.fromExternalString(inBlock2.get(0, i).toString()); | ||
| FrameBlock out = new FrameBlock(schema); | ||
| out.copy(inBlock1); | ||
| out.setSchema(schema); |
Contributor
There was a problem hiding this comment.
I would have liked it to apply it to the data inside the columns, not first copying and then setting the schema.
this implementation just modify metadata you set, not reallocating the columns with the right data.
But on the other hand this is a great start, where we can easily add the functionality inside Frame Block and Arrays.
Do you want to do it ? or should i add that part?
Baunsgaard
changed the title
Contributor
|
Hi @Shafaq-Siddiqi , |
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Nov 25, 2022
This commit adds the ApplySchema primitive to change the schema of an already allocated FrameBlock in DML. Closes apache#1732
Contributor
|
Closing, see: #1737 |
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Nov 28, 2022
This commit adds the ApplySchema primitive to change the schema of an already allocated FrameBlock in DML. Closes apache#1732
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Dec 9, 2022
This commit adds the ApplySchema primitive to change the schema of an already allocated FrameBlock in DML. Closes apache#1732
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Dec 10, 2022
This commit adds the ApplySchema primitive to change the schema of an already allocated FrameBlock in DML. Closes apache#1732
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Dec 10, 2022
This commit adds the ApplySchema primitive to change the schema of an already allocated FrameBlock in DML. Closes apache#1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which will apply the given schema to a existing frame