Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1107: Broadcast join on non-leaf node scans only first data file. - #193

Closed
babokim wants to merge 3 commits into
apache:masterfrom
babokim:TAJO-1107
Closed

TAJO-1107: Broadcast join on non-leaf node scans only first data file.#193
babokim wants to merge 3 commits into
apache:masterfrom
babokim:TAJO-1107

Conversation

@babokim

@babokim babokim commented Oct 8, 2014

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ensure that each broadcastFragments will must have its corresponding element in broadcastScan array. Nevertheless, what eachFragment variable is not used in the for-loop block seems to not be intuitive. Could you replace it by the loop using broadcastScans?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll replace broadcastFragments with broadcastScans before committing.

@hyunsik

hyunsik commented Oct 8, 2014

Copy link
Copy Markdown
Member

+1
The patch looks good to me. The patch exactly fixes the bug and includes enough unit tests for all cases. I leave one trivial comment. Before committing it, please reflect the comment if you accept.

Thanks,
Hyunsik

@asfgit asfgit closed this in 5f64cbb Oct 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants