Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1249: Tajo Should Check File Format is allowed. - #305

Closed
charsyam wants to merge 1 commit into
apache:masterfrom
charsyam:feature/TAJO-1249
Closed

TAJO-1249: Tajo Should Check File Format is allowed.#305
charsyam wants to merge 1 commit into
apache:masterfrom
charsyam:feature/TAJO-1249

Conversation

@charsyam

Copy link
Copy Markdown
Contributor

Currently Tajo just show NullPointException when can't understand file format

default> create external table table1 ( id int, name text, score float, type text, mytime int, mytime2 date) using TEXT1 location 'file:/Users/charsyam/tajo/table';
ERROR: java.lang.NullPointerException

after patch

default> create table table1 (       id int,       name text,       score float,       type text, mytime int) USING csv1;
ERROR: csv1 is not supported storage type.

I added code in LogicalPlanner.java because I think it is more clear and easy to understand.

@blrunner

Copy link
Copy Markdown
Contributor

Hi @charsyam

Thank you for your contribution.
LogicalPlanVerifier provide logical plan validation. I think you'd better update LogicalPlanVerifier::visitCreateTable.

Cheers
Jaehwa

@blrunner

Copy link
Copy Markdown
Contributor

I give new opinion again. I think you'd better use PreLogicalPlanVerifier instead of LogicalPlanVerifier. PreLogicalPlanVerifier provide query validation before creating local plan.

@charsyam charsyam closed this Dec 19, 2014
@charsyam
charsyam deleted the feature/TAJO-1249 branch December 19, 2014 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants