Describe the bug
Six regions in amber are unreachable or unused. Each was verified by grep across all file types (excluding target/, .git/, node_modules/), including the Python side and .proto files where an RPC constant could be mirrored.
-
PekkoActorService.sendToSelfOnce and ask have zero call sites. Both appear only in their own declarations — ask's only other hit is the pekko.pattern.ask inside its own body. Three test classes do subclass PekkoActorService, but their overrides are sendToSelfWithFixedDelay and scheduleWithFixedDelay, neither of these.
-
AsyncRPCClient.IgnoreReply = -1 is unreferenced. Every other hit is the distinct IgnoreReplyAndDoNotLog = -2 (used at WorkerTimerService.scala:59 and AsyncRPCClient.scala:196). There is no Python mirror — grep -rni "ignore_reply|ignorereply" over amber/src/main/python and src/test/python is empty — and no proto sentinel, since commandId is a plain int64.
-
ExecutionResultService.convertWebResultUpdate's case _ => throw is unreachable. WebOutputMode is a sealed abstract class with exactly three final case class subtypes, all in the same file and all matched above the default arm.
-
UserQuotaResource's executions == null is a dead guard — jOOQ's fetch() returns a non-null Result. The sibling getUserAccessedWorkflow a few lines above does an unguarded .fetchInto(...).
-
ResultExportService's zipStream == null guard is unreachable. exportOperatorsAsZip has exactly two exits: it throws, or it returns a new StreamingOutput { … } literal. Note the sibling guard on the next path is not dead — exportOperatorResultAsStream genuinely can return null, and two tests assert the error it raises.
-
WorkflowService.lastCompletedLogicalPlan is a write-only var — its declaration, a single write, and a spec doc-comment are the only occurrences. Zero readers.
How to reproduce?
Grep each symbol. For (3), removing the default arm produces no match may not be exhaustive warning, which confirms the match was already total.
Version/Branch
main
Task Type
Describe the bug
Six regions in amber are unreachable or unused. Each was verified by grep across all file types (excluding
target/,.git/,node_modules/), including the Python side and.protofiles where an RPC constant could be mirrored.PekkoActorService.sendToSelfOnceandaskhave zero call sites. Both appear only in their own declarations —ask's only other hit is thepekko.pattern.askinside its own body. Three test classes do subclassPekkoActorService, but their overrides aresendToSelfWithFixedDelayandscheduleWithFixedDelay, neither of these.AsyncRPCClient.IgnoreReply = -1is unreferenced. Every other hit is the distinctIgnoreReplyAndDoNotLog = -2(used atWorkerTimerService.scala:59andAsyncRPCClient.scala:196). There is no Python mirror —grep -rni "ignore_reply|ignorereply"overamber/src/main/pythonandsrc/test/pythonis empty — and no proto sentinel, sincecommandIdis a plainint64.ExecutionResultService.convertWebResultUpdate'scase _ => throwis unreachable.WebOutputModeis asealed abstract classwith exactly threefinal case classsubtypes, all in the same file and all matched above the default arm.UserQuotaResource'sexecutions == nullis a dead guard — jOOQ'sfetch()returns a non-nullResult. The siblinggetUserAccessedWorkflowa few lines above does an unguarded.fetchInto(...).ResultExportService'szipStream == nullguard is unreachable.exportOperatorsAsZiphas exactly two exits: it throws, or it returns anew StreamingOutput { … }literal. Note the sibling guard on the next path is not dead —exportOperatorResultAsStreamgenuinely can return null, and two tests assert the error it raises.WorkflowService.lastCompletedLogicalPlanis a write-only var — its declaration, a single write, and a spec doc-comment are the only occurrences. Zero readers.How to reproduce?
Grep each symbol. For (3), removing the default arm produces no
match may not be exhaustivewarning, which confirms the match was already total.Version/Branch
main
Task Type