[Compiler Refactor 1] Introduce refactored OpExecConfig#1791
Merged
Conversation
This was referenced Jan 17, 2023
zuozhiw
changed the title
zuozhiw
added a commit
that referenced
this pull request
Jan 19, 2023
…pport new OpExecConfig interface (#1796) This PR is a follow-up of #1791 , where a new `OpExecConfig` interface is introduced for the new workflow compiler layer. This PR changes the `OperatorDescriptor` interface to use the new `OpExecConfig`. Currently, the old and new interfaces exist in parallel. After all migrations are completed, the old interface will be removed. New interfaces: ``` def newOperatorExecutor(operatorSchemaInfo: OperatorSchemaInfo): NewOpExecConfig = { throw new UnsupportedOperationException( "operator " + operatorIdentifier + " is not migrated to new OpExec API" ) } // a logical operator corresponds multiple physical operators (a small DAG) def operatorExecutorMultiLayer(operatorSchemaInfo: OperatorSchemaInfo): PhysicalPlan = { new PhysicalPlan(List(newOperatorExecutor(operatorSchemaInfo)), List()) ``` Logical operators that correpond to a single physical operator will implement `newOperatorExecutor` interface. Logical operators that correpond to a **multiple** physical operator (such as aggregate) will implement `operatorExecutorMultiLayer` interface.
zuozhiw
changed the title
zuozhiw
added a commit
that referenced
this pull request
Jan 31, 2023
…onfig class (#1794) This PR is a follow up of #1791 . In #1791 a new `OpExecConfig` class is introduced. This PR updates the simple operators that are mostly one-to-one to use the new class. Most changes are one-line changes that directly map from the old API to the new API. Changes to more complicated operators (join, aggregate, etc..) will be completed in subsequent PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the efforts to refactor the workflow compiler layer.
This PR introduces a new class,
NewOpExecConfig, which captures all the information related to a physical operator. This class will replace the existingOpExecConfigandWorkerLayerin the future.