[Compiler Refactor 4] Introduce new APIs in OperatorDescriptor to support new OpExecConfig interface#1796
Merged
Merged
Conversation
shengquan-ni
approved these changes
Jan 18, 2023
Contributor
|
@zuozhiw can we add an annotation to indicate the deprecation of the old API? Users may be confused about which API to use now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1791 , where a new
OpExecConfiginterface is introduced for the new workflow compiler layer. This PR changes theOperatorDescriptorinterface to use the newOpExecConfig. Currently, the old and new interfaces exist in parallel. After all migrations are completed, the old interface will be removed.New interfaces:
Logical operators that correpond to a single physical operator will implement
newOperatorExecutorinterface.Logical operators that correpond to a multiple physical operator (such as aggregate) will implement
operatorExecutorMultiLayerinterface.