feat(gui): Improve UI for operator port metrics #3477
Merged
jaeyun0503 merged 19 commits intomasterfrom Jul 8, 2025
Merged
Conversation
aglinxinyuan
requested changes
Jun 18, 2025
Contributor
There was a problem hiding this comment.
Remove the counts on top of each operator since this information is already included on the input and output ports. Also, try to make the text on the same vertical line. Currently, the text for input count and output count for the same operator is not aligned.
Contributor
Author
|
@aglinxinyuan Finished making changes and requested a new review |
aglinxinyuan
requested changes
Jul 5, 2025
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
Left mirror comments
jaeyun0503
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of port metrics so that no matter which operator is highlighted, the port metrics (port id and port count) on both input and output would be always shown to user. This change was made to comply with ui improvement plan so that users have a better overview of the input and output data counts.
In addition to the change mentioned above, the layers between links and texts are differentiated so that the texts can no longer be blocked by arrows.
Attached images include a brief overview of the UI, and a zoomed-in image of an operator that explains the latter change.
