Skip to content

fix: change detection scheduling regression #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aglinxinyuan merged 1 commit into from
Apr 28, 2026
Merged

fix: change detection scheduling regression #4537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions frontend/src/app/dashboard/component/dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,18 +147,14 @@ export class DashboardComponent implements OnInit {
.getSetting("logo")
.pipe(untilDestroyed(this))
.subscribe(dataUri => {
this.ngZone.run(() => {
this.logo = dataUri;
});
this.logo = dataUri;
});

this.adminSettingsService
.getSetting("mini_logo")
.pipe(untilDestroyed(this))
.subscribe(dataUri => {
this.ngZone.run(() => {
this.miniLogo = dataUri;
});
this.miniLogo = dataUri;
});

this.adminSettingsService
Expand All @@ -175,9 +171,7 @@ export class DashboardComponent implements OnInit {
.getSetting(tab)
.pipe(untilDestroyed(this))
.subscribe(value => {
this.ngZone.run(() => {
this.sidebarTabs[tab] = value === "true";
});
this.sidebarTabs[tab] = value === "true";
});
});
}
Expand Down
17 changes: 5 additions & 12 deletions frontend/src/app/dashboard/component/user/search-results/search-results.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { Component, EventEmitter, Input, NgZone, Output } from "@angular/core";
import { Component, EventEmitter, Input, Output } from "@angular/core";
import { DashboardEntry } from "../../../type/dashboard-entry";
import { UserService } from "../../../../common/service/user/user.service";

Expand Down Expand Up @@ -47,10 +47,7 @@ export class SearchResultsComponent {
@Output() notifyWorkflow = new EventEmitter<void>();
@Output() refresh = new EventEmitter<void>();

constructor(
private userService: UserService,
private ngZone: NgZone
) {}
constructor(private userService: UserService) {}

getUid(): number | undefined {
return this.userService.getCurrentUser()?.uid;
Expand All @@ -73,14 +70,10 @@ export class SearchResultsComponent {
if (this.resetCounter !== originalResetCounter) {
return;
}
this.ngZone.run(() => {
this.entries = [...this.entries, ...results.entries];
this.more = results.more;
});
this.entries = [...this.entries, ...results.entries];
this.more = results.more;
} finally {
this.ngZone.run(() => {
this.loading = false;
});
this.loading = false;
}
}

Expand Down
6 changes: 4 additions & 2 deletions frontend/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { enableProdMode } from "@angular/core";
import { enableProdMode, provideZoneChangeDetection } from "@angular/core";
import { platformBrowserDynamic } from "@angular/platform-browser-dynamic";

import { AppModule } from "./app/app.module";
Expand All @@ -28,7 +28,9 @@ if (environment.production) {
}

platformBrowserDynamic()
.bootstrapModule(AppModule)
.bootstrapModule(AppModule, {
applicationProviders: [provideZoneChangeDetection()],
})
.then(() => {
console.log("Texera application bootstrap completed successfully");
})
Expand Down
Loading