Skip to content

Zuozhi's bad hello world code#5

Merged
prakul merged 3 commits into
masterfrom
zuozhi
Apr 3, 2016
Merged

Zuozhi's bad hello world code#5
prakul merged 3 commits into
masterfrom
zuozhi

Conversation

@zuozhiw
Copy link
Copy Markdown
Contributor

@zuozhiw zuozhiw commented Mar 29, 2016

Prakul please review the bad code, Thanks.

Zuozhi

* Hello world!
*
*/
public class DummyHelloWorld
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Java, the filename and the class name has to be equal.

@chenlica
Copy link
Copy Markdown
Contributor

@prakul Please do the code review as requested.

{
public static void main( String[] args )
{
//Bad comments
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this comment

@prakul prakul merged commit a135160 into master Apr 3, 2016
@zuozhiw zuozhiw deleted the zuozhi branch April 6, 2016 00:01
aglinxinyuan added a commit that referenced this pull request Apr 29, 2026
The credit-issue-on-pr-merge job's script was truncated mid-statement,
causing every PR merge to fail with SyntaxError: Unexpected token ')'.

Add the missing per-issue body: skip cross-repo, diff current vs.
credited assignees, removeAssignees for those no longer credited, and
addAssignees for newly credited authors. Both calls are wrapped in
try/catch so a permissions or 422 hiccup on one issue doesn't abort
the rest.

Verified end-to-end on aglinxinyuan/texera: issue #4 correctly received
@aglinxinyuan as assignee after PR #5 merged with 'Closes #4'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants