Skip to content

Display an image in the operator panel#679

Merged
zuozhiw merged 10 commits into
masterfrom
stephen-display-an-image-in-the-operator-box
Feb 9, 2019
Merged

Display an image in the operator panel#679
zuozhiw merged 10 commits into
masterfrom
stephen-display-an-image-in-the-operator-box

Conversation

@StephenLiu7
Copy link
Copy Markdown
Contributor

@StephenLiu7 StephenLiu7 commented Nov 29, 2018

This PR implements the #5 issue in GUI improvement ideas, displaying an image in the operator box. We want to store the pictures in the backend folder, but currently they are stored in the front end folder under the new_gui/src/assets/ folder.

The majority of code changes are within the following 1 file:
joint-ui.service.ts

Following images show the operator box with images in the workflow panel:
screen shot 2018-12-07 at 11 09 20 am

Currently, images are stored in the front end folder.
@henrychen0220
Copy link
Copy Markdown
Contributor

I have 2 proposals for the operator design:

The first proposal is to include the image at the operator bar and display only the image (not including the operator name) when the operator is displayed in jointjs.

This proposal follows the design of alteryx.

image

Here is a prototype I made that requires further modifications:

proposal1

The second proposal is to keep the current design of the operator and improve the operator appearance based on the current design.

Here is a prototype I made for this proposal:

proposal2

@zuozhiw and @avinash0161 any suggestions or preferences?

@chenlica
Copy link
Copy Markdown
Contributor

The first design can show a bigger icon, making it easier to see and understand by the user.

@avinash0161
Copy link
Copy Markdown
Contributor

I prefer the second approach. Assume a workflow containing many operators. If we use the second approach, It will be easier for the user to get an overall picture and do a mental dry run. If we use the first approach, he will have to hover over each operator to see what it means. If there are many operators, it will be very difficult for him to get the whole idea just by glancing at the workflow.

@zuozhiw zuozhiw changed the title Display an image in the operator panal Display an image in the operator panel Jan 3, 2019
@StephenLiu7
Copy link
Copy Markdown
Contributor Author

I redesigned the appearance of operators in the workflow panel.
I also changed the link from straight lines to curves with the ability to avoid "obstacles" in the panel.
Here is the picture showing the change.
screen shot 2019-02-01 at 4 53 59 pm

Copy link
Copy Markdown
Contributor

@zuozhiw zuozhiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@zuozhiw zuozhiw merged commit 1e4491e into master Feb 9, 2019
@zuozhiw zuozhiw deleted the stephen-display-an-image-in-the-operator-box branch February 9, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants