test(frontend): extend WorkflowActionService coverage#6352
Conversation
Automated Reviewer SuggestionsBased on the
|
There was a problem hiding this comment.
Pull request overview
This PR extends the Angular/Vitest unit test suite for WorkflowActionService (frontend workflow-graph model layer) to improve behavioral coverage across workflow reload/reset, metadata/settings setters, shared-editing temp-workflow connection toggling, dynamic ports, highlighting, and several graph state mutations.
Changes:
- Adds new spec cases for
reloadWorkflow,clearWorkflow, andresetAsNewWorkflow, including undo/redo and viewport expectations. - Adds coverage for workflow metadata + settings setters and shared-editing temp workflow connect/disconnect paths.
- Adds tests for dynamic port add/remove, disable/reuse/view-result sets, highlighting,
setOperatorVersion,setPortProperty, and top-left positioning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6352 +/- ##
============================================
+ Coverage 61.16% 61.61% +0.45%
Complexity 3381 3381
============================================
Files 1140 1142 +2
Lines 44929 45020 +91
Branches 4943 4948 +5
============================================
+ Hits 27481 27741 +260
+ Misses 15930 15729 -201
- Partials 1518 1550 +32
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ests deterministic
What changes were proposed in this PR?
Extends the
WorkflowActionServicespec (was ~52% covered):reloadWorkflow/clearWorkflow/resetAsNewWorkflow, metadata/name/settings/batch-size/execution-mode/published setters, temp-workflow yjs ws-provider connect/disconnect, add/remove port, disable/reuse/view-result sets, highlight ports/elements,setOperatorVersion/setPortProperty, and auto-layout positioning.Any related issues, documentation, discussions?
Closes #6349.
How was this PR tested?
Added tests to the existing spec (now 37), reusing its real TexeraGraph/joint-graph harness with undo-redo and ws-provider spies. Verified locally with Vitest (
ng test --watch=false --include=...) and CI'sformat:cigate (prettier-eslint + eslint) clean. Test-only change — no production code is modified.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])