Skip to content

test(frontend): extend WorkflowActionService coverage#6352

Merged
aglinxinyuan merged 2 commits into
apache:mainfrom
aglinxinyuan:test-fe-workflow-action
Jul 12, 2026
Merged

test(frontend): extend WorkflowActionService coverage#6352
aglinxinyuan merged 2 commits into
apache:mainfrom
aglinxinyuan:test-fe-workflow-action

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Extends the WorkflowActionService spec (was ~52% covered): reloadWorkflow/clearWorkflow/resetAsNewWorkflow, metadata/name/settings/batch-size/execution-mode/published setters, temp-workflow yjs ws-provider connect/disconnect, add/remove port, disable/reuse/view-result sets, highlight ports/elements, setOperatorVersion/setPortProperty, and auto-layout positioning.

Any related issues, documentation, discussions?

Closes #6349.

How was this PR tested?

Added tests to the existing spec (now 37), reusing its real TexeraGraph/joint-graph harness with undo-redo and ws-provider spies. Verified locally with Vitest (ng test --watch=false --include=...) and CI's format:ci gate (prettier-eslint + eslint) clean. Test-only change — no production code is modified.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.8 [1M context])

Copilot AI review requested due to automatic review settings July 11, 2026 23:47
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Jul 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Angular/Vitest unit test suite for WorkflowActionService (frontend workflow-graph model layer) to improve behavioral coverage across workflow reload/reset, metadata/settings setters, shared-editing temp-workflow connection toggling, dynamic ports, highlighting, and several graph state mutations.

Changes:

  • Adds new spec cases for reloadWorkflow, clearWorkflow, and resetAsNewWorkflow, including undo/redo and viewport expectations.
  • Adds coverage for workflow metadata + settings setters and shared-editing temp workflow connect/disconnect paths.
  • Adds tests for dynamic port add/remove, disable/reuse/view-result sets, highlighting, setOperatorVersion, setPortProperty, and top-left positioning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

codecov-commenter commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.61%. Comparing base (8ee0cfb) to head (3f322ca).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6352      +/-   ##
============================================
+ Coverage     61.16%   61.61%   +0.45%     
  Complexity     3381     3381              
============================================
  Files          1140     1142       +2     
  Lines         44929    45020      +91     
  Branches       4943     4948       +5     
============================================
+ Hits          27481    27741     +260     
+ Misses        15930    15729     -201     
- Partials       1518     1550      +32     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from 5f6daca
agent-service 44.59% <ø> (ø) Carriedforward from 5f6daca
amber 66.58% <ø> (ø) Carriedforward from 5f6daca
computing-unit-managing-service 9.97% <ø> (ø) Carriedforward from 5f6daca
config-service 52.30% <ø> (ø) Carriedforward from 5f6daca
file-service 63.97% <ø> (ø) Carriedforward from 5f6daca
frontend 54.42% <ø> (+1.11%) ⬆️ Carriedforward from 5f6daca
notebook-migration-service 78.94% <ø> (ø) Carriedforward from 5f6daca
pyamber 91.18% <ø> (ø) Carriedforward from 5f6daca
workflow-compiling-service 55.14% <ø> (ø) Carriedforward from 5f6daca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aglinxinyuan aglinxinyuan requested a review from mengw15 July 12, 2026 00:46

@mengw15 mengw15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aglinxinyuan aglinxinyuan added this pull request to the merge queue Jul 12, 2026
Merged via the queue into apache:main with commit 95b9935 Jul 12, 2026
21 checks passed
@aglinxinyuan aglinxinyuan deleted the test-fe-workflow-action branch July 12, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit test coverage for WorkflowActionService

4 participants