test(frontend): add unit tests for storage util - #6620
Merged
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Vitest unit-test coverage for the frontend browser storage utility helpers in storage.ts, addressing issue #6619 by validating expected behaviors for localStorage/sessionStorage wrappers and jsonCast.
Changes:
- Add a new
storage.spec.tscoveringlocalSetObject/localGetObject/localRemoveObjectandsessionSetObject/sessionGetObject/sessionRemoveObject. - Add tests for
jsonCastsuccess and invalid-JSON throw behavior. - Use deterministic mocked
localStorage/sessionStorageviavi.stubGlobalto isolate tests from the runtime environment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
frontend/src/app/common/util/storage.spec.ts, a new Vitest spec forstorage.ts, which previously had no dedicated unit tests.Any related issues, documentation, discussions?
Closes: #6619
How was this PR tested?
cd frontend && node --max-old-space-size=8192 ./node_modules/nx/dist/bin/nx.js test gui --watch=false --include=src/app/common/util/storage.spec.ts, expect all 12 tests passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF