test(file-service): cover DatasetResource path validation - #6701
Merged
aglinxinyuan merged 1 commit intoJul 22, 2026
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds focused ScalaTest unit coverage for DatasetResource.validateAndNormalizeFilePathOrThrow, improving confidence in file-path validation behavior within the file-service without relying on the heavier DatasetResourceSpec integration harness.
Changes:
- Introduce a new lightweight spec that directly exercises
validateAndNormalizeFilePathOrThrow. - Add tests covering null/empty/whitespace inputs, normalization-to-null invalid traversal, absolute-path rejection, and relative-path normalization behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6700
How was this PR tested?
sbt "FileService/testOnly *DatasetResourcePathSpec", expect all 7 tests passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF