revert: route all Codecov flags through the deferred workflow_run upload#6840
Merged
Merged
Conversation
… upload …" This reverts commit a8bb1ec.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6840 +/- ##
============================================
+ Coverage 76.28% 76.44% +0.15%
- Complexity 3452 3455 +3
============================================
Files 1161 1161
Lines 45916 45922 +6
Branches 5099 5101 +2
============================================
+ Hits 35025 35103 +78
+ Misses 9327 9270 -57
+ Partials 1564 1549 -15
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts #6730 by removing the deferred workflow_run-based Codecov upload pipeline and restoring inline Codecov uploads directly in the main Build reusable workflow.
Changes:
- Removed the dedicated deferred Codecov upload workflow (
.github/workflows/codecov-upload.yml). - Switched CI back to inline Codecov uploads in
.github/workflows/build.yml(coverage + test results across frontend/amber/platform/pyamber/agent-service jobs). - Removed the staging helper script used by the deferred pipeline (
.github/scripts/stage-codecov.sh).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/codecov-upload.yml |
Removed the deferred Codecov uploader workflow (revert of #6730 behavior). |
.github/workflows/build.yml |
Restored inline Codecov uploads for coverage and test results across multiple CI jobs. |
.github/scripts/stage-codecov.sh |
Removed the staging script used to prepare artifacts for deferred uploads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aglinxinyuan
changed the title
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🟢 | bs=10 sw=10 sl=64 | 439 | 0.268 | 22,162/27,849/27,849 us | 🟢 -20.7% / 🔴 +75.6% |
| 🟢 | bs=100 sw=10 sl=64 | 942 | 0.575 | 105,145/116,763/116,763 us | 🟢 -26.9% / 🔴 +9.7% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,075 | 0.656 | 923,981/1,042,772/1,042,772 us | 🔴 +5.8% / 🟢 -5.1% |
Baseline details
Latest main 931b0d4 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 439 tuples/sec | 440 tuples/sec | 767.66 tuples/sec | -0.2% | -42.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.268 MB/s | 0.268 MB/s | 0.469 MB/s | 0.0% | -42.8% |
| bs=10 sw=10 sl=64 | p50 | 22,162 us | 23,815 us | 12,623 us | -6.9% | +75.6% |
| bs=10 sw=10 sl=64 | p95 | 27,849 us | 35,116 us | 16,011 us | -20.7% | +73.9% |
| bs=10 sw=10 sl=64 | p99 | 27,849 us | 35,116 us | 18,856 us | -20.7% | +47.7% |
| bs=100 sw=10 sl=64 | throughput | 942 tuples/sec | 926 tuples/sec | 998.44 tuples/sec | +1.7% | -5.7% |
| bs=100 sw=10 sl=64 | MB/s | 0.575 MB/s | 0.565 MB/s | 0.609 MB/s | +1.8% | -5.6% |
| bs=100 sw=10 sl=64 | p50 | 105,145 us | 104,344 us | 100,463 us | +0.8% | +4.7% |
| bs=100 sw=10 sl=64 | p95 | 116,763 us | 159,787 us | 106,400 us | -26.9% | +9.7% |
| bs=100 sw=10 sl=64 | p99 | 116,763 us | 159,787 us | 117,712 us | -26.9% | -0.8% |
| bs=1000 sw=10 sl=64 | throughput | 1,075 tuples/sec | 1,084 tuples/sec | 1,034 tuples/sec | -0.8% | +4.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.656 MB/s | 0.661 MB/s | 0.631 MB/s | -0.8% | +3.9% |
| bs=1000 sw=10 sl=64 | p50 | 923,981 us | 919,281 us | 973,294 us | +0.5% | -5.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,042,772 us | 985,868 us | 1,019,213 us | +5.8% | +2.3% |
| bs=1000 sw=10 sl=64 | p99 | 1,042,772 us | 985,868 us | 1,049,896 us | +5.8% | -0.7% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,455.63,200,128000,439,0.268,22161.57,27848.71,27848.71
1,100,10,64,20,2124.23,2000,1280000,942,0.575,105144.80,116762.99,116762.99
2,1000,10,64,20,18599.78,20000,12800000,1075,0.656,923980.55,1042772.22,1042772.22
Yicong-Huang
approved these changes
Jul 23, 2026
aglinxinyuan
enabled auto-merge
July 23, 2026 21:26
This was referenced Jul 24, 2026
Yicong-Huang
pushed a commit
to Yicong-Huang/texera
that referenced
this pull request
Jul 24, 2026
apache#6852) ### What changes were proposed in this PR? Step 1 of a Codecov carryforward reset (see apache#6850). The deferred `workflow_run` upload experiment (apache#6730, apache#6824) — since reverted (apache#6840, apache#6837) — left Codecov's carryforward chain stuck: every PR renders its **own** flag as `Carriedforward` instead of a fresh delta, so a PR's real coverage change never surfaces (full diagnosis in apache#6839). Reverting the upload path alone does not un-stick the chain; the poisoned base report on `main` has to be flushed. This PR removes `flag_management.default_rules.carryforward` so the next full `main` build rebaselines Codecov against the current flag set, dropping the stale carried sessions. **This is intentionally temporary.** A follow-up PR restores `carryforward: true` once `main` has a clean full-build baseline. During the window, single-stack PRs may show non-run flags as `?` — expected, and the reason carryforward exists. Ordered operational steps (per Codecov's [reset guidance](https://community.codecov.com/t/remove-old-carryforward-flag/3428)): 1. Merge this PR. 2. Let a full build run on `main` (all 11 flags upload fresh; nothing carried). 3. Merge the follow-up PR re-enabling carryforward. 4. Rebase open PRs onto the new `main`. ### Any related issues, documentation, discussions? Closes apache#6850 ### How was this PR tested? Config-only change. Validated `codecov.yml` parses as valid YAML (`yaml.safe_load`) and that the top-level keys are now `ignore`, `coverage`, `comment` — the `flag_management` block is removed as intended. No behavior to unit-test; the effect is verifiable on `main` post-merge by confirming PR comments show fresh flag deltas again. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Reverts #6730 ("ci: route all Codecov flags through the deferred workflow_run upload").
Together with the already-merged #6837 (revert of #6824), this fully backs out the deferred
workflow_runCodecov upload: the inlinecodecov/codecov-actionsteps are restored inbuild.ymlfor every flag, and bothcodecov-upload.ymland.github/scripts/stage-codecov.share removed.The deferred approach regressed coverage — because the upload moved out of the Required Checks run, Codecov built each PR's comment from carryforward before the deferred upload landed, so every PR showed its own flag as
Carriedforwardinstead of a fresh delta (full analysis in #6839). Restoring inline uploads brings back fresh per-PR coverage.Any related issues, documentation, discussions?
Closes #6839
How was this PR tested?
Revert of CI-only workflow changes; no product code is affected. Verified on the branch that
build.ymlrestores the inlinecodecov-actionupload steps for all flags (frontend, amber, amber-integration, the six platform services, pyamber, agent-service) and thatcodecov-upload.ymlandstage-codecov.share gone. Fresh (non-carryforward) coverage is confirmed once this merges and the next PR's Codecov comment again shows its own flag with a delta.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])