Skip to content

fix: raise default WebSocket payload limit to avoid dropping large result frames #6858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aicam wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: raise default WebSocket payload limit to avoid dropping large result frames #6858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/k8s/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ texeraEnvVars:
- name: SCHEDULE_GENERATOR_ENABLE_COST_BASED_SCHEDULE_GENERATOR
value: "true"
- name: MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB
value: "64"

@Yicong-Huang Yicong-Huang Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are those values kept twice in the source code?

@aicam aicam Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is config which has default value and one is in Kubernetes which overwrite local config. Some important config envs are in Kubernetes setting.

@Yicong-Huang Yicong-Huang Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I assume the ones in kubernetes is a subset of overriding the defaults.

value: "1024"
- name: MAX_NUM_OF_RUNNING_COMPUTING_UNITS_PER_USER
value: "10"
- name: KUBERNETES_COMPUTING_UNIT_CPU_LIMIT_OPTIONS
Expand Down
2 changes: 1 addition & 1 deletion common/config/src/main/resources/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ web-server {
clean-all-execution-results-on-server-start = false
clean-all-execution-results-on-server-start = ${?WEB_SERVER_CLEAN_ALL_EXECUTION_RESULTS_ON_SERVER_START}

max-workflow-websocket-request-payload-size-kb = 64
max-workflow-websocket-request-payload-size-kb = 1024
max-workflow-websocket-request-payload-size-kb = ${?MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB}
}

Expand Down
Loading