fix(k8s, v1.2): add missing AUTH_JWT_SECRET to values-development.yaml - #7000
Open
Yicong-Huang wants to merge 1 commit into
Open
fix(k8s, v1.2): add missing AUTH_JWT_SECRET to values-development.yaml #7000Yicong-Huang wants to merge 1 commit into
Yicong-Huang wants to merge 1 commit into
Conversation
### What changes were proposed in this PR? Adds the `AUTH_JWT_SECRET` environment variable to `bin/k8s/values-development.yaml`. The default `values.yaml` sets `AUTH_JWT_SECRET` inside `texeraEnvVars`, but `values-development.yaml` overrides `texeraEnvVars` as a **whole list**. Helm replaces lists rather than merging them, so a local install with `-f values-development.yaml` silently drops `AUTH_JWT_SECRET` from every Texera service. The computing-unit manager reads this variable directly via `env.get(KEY).get` when launching a Kubernetes computing unit (`ComputingUnitManagingResource.scala`), so the missing value makes **computing-unit creation fail hard**: ``` java.util.NoSuchElementException: None.get POST /api/computing-unit/create HTTP/1.1" 500 ``` Any local Kubernetes deployment following the development values hits this the moment a user tries to create a computing unit. The fix adds the variable with the **same development-only default** already used in `values.yaml`, so all services share one consistent JWT signing secret. ### Any related issues, documentation, discussions? None — standalone bug fix in the development values overlay. Independent of any other in-flight `bin/k8s` work. ### How was this PR tested? Reproduced and verified on a local minikube cluster (`helm install ... -f values-development.yaml`): - **Before:** creating a Kubernetes computing unit returned HTTP 500; the computing-unit manager logged `java.util.NoSuchElementException: None.get`. `kubectl exec` into the manager pod confirmed `AUTH_JWT_SECRET` was unset. - **After** (`helm upgrade` with this change): `AUTH_JWT_SECRET` is present on the manager (and all services), the manager rolled out cleanly, and the `None.get` error no longer occurs. Also confirmed the added value is byte-for-byte identical to the `AUTH_JWT_SECRET` default in `values.yaml`, so development and production use the same variable and the dev overlay stops diverging. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.8) --------- (backported from commit f14cd39) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #6610 to
release/v1.2, cherry-picked from f14cd39. The cherry-pick applied cleanly.Follows the Direct Backport Push convention; opened as a PR (rather than a direct push) per a backport-coverage audit.
Any related issues, documentation, discussions?
Backport of #6610.
How was this PR tested?
Release-branch CI runs on this PR. Cherry-pick applied cleanly onto
release/v1.2; no manual conflict resolution was needed.Was this PR authored or co-authored using generative AI tooling?
Yes — backport prepared with Claude Code (mechanical cherry-pick; the change itself is #6610 by its original author).
🤖 Generated with Claude Code