Skip to content

fix(visualization): retarget attributeTypeRules at the properties they name #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kz930 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(visualization): retarget attributeTypeRules at the properties they name #7249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1d1f5
fix(visualization): retarget attributeTypeRules at the properties the…
kz930 Aug 2, 2026
131e807
chore: re-run CI
kz930 Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...che/texera/amber/operator/visualization/ScatterMatrixChart/ScatterMatrixChartOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,13 @@ import org.apache.texera.amber.operator.metadata.{OperatorGroupConstants, Operat
import org.apache.texera.amber.pybuilder.PythonTemplateBuilder

import javax.validation.constraints.{NotEmpty, NotNull}
// Type constraint: every axis of the matrix is plotted numerically. The key is the
// PROPERTY name -- the `@JsonProperty` value, which is what the property editor looks
// up -- and this operator's is "Selected Attributes"; keyed "value" it matched nothing.
@JsonSchemaInject(json = """
{
"attributeTypeRules": {
"value": {
"Selected Attributes": {
"enum": ["integer", "long", "double"]
}
}
Expand Down
9 changes: 1 addition & 8 deletions ...in/scala/org/apache/texera/amber/operator/visualization/funnelPlot/FunnelPlotOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
package org.apache.texera.amber.operator.visualization.funnelPlot

import com.fasterxml.jackson.annotation.{JsonProperty, JsonPropertyDescription}
import com.kjetland.jackson.jsonSchema.annotations.{JsonSchemaInject, JsonSchemaTitle}
import com.kjetland.jackson.jsonSchema.annotations.JsonSchemaTitle
import org.apache.texera.amber.core.tuple.{AttributeType, Schema}
import org.apache.texera.amber.pybuilder.PythonTemplateBuilder.PythonTemplateBuilderStringContext
import org.apache.texera.amber.pybuilder.PyStringTypes.EncodableString
Expand All @@ -31,13 +31,6 @@ import org.apache.texera.amber.operator.metadata.{OperatorGroupConstants, Operat
import org.apache.texera.amber.pybuilder.PythonTemplateBuilder

import javax.validation.constraints.NotNull
@JsonSchemaInject(json = """
{
"attributeTypeRules": {
"title": "string"
}
}
""")
class FunnelPlotOpDesc extends PythonOperatorDescriptor {

@JsonProperty(required = true)
Expand Down
8 changes: 5 additions & 3 deletions .../src/main/scala/org/apache/texera/amber/operator/visualization/lineChart/LineConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@ import org.apache.texera.amber.operator.metadata.annotations.AutofillAttributeNa

import javax.validation.constraints.NotNull

//type constraint: value can only be numeric
// Type constraint: both axes can only be numeric. The keys are the PROPERTY names --
// the `@JsonProperty` values, which is what the property editor looks up -- not the
// Scala field names; keyed by the latter the rule matched nothing.
@JsonSchemaInject(json = """
{
"attributeTypeRules": {
"yValue": {
"y": {
"enum": ["integer", "long", "double"]
},
"xValue": {
"x": {
"enum": ["integer", "long", "double"]
}
}
Expand Down
9 changes: 1 addition & 8 deletions .../org/apache/texera/amber/operator/visualization/scatter3DChart/Scatter3dChartOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
package org.apache.texera.amber.operator.visualization.scatter3DChart

import com.fasterxml.jackson.annotation.{JsonProperty, JsonPropertyDescription}
import com.kjetland.jackson.jsonSchema.annotations.{JsonSchemaInject, JsonSchemaTitle}
import com.kjetland.jackson.jsonSchema.annotations.JsonSchemaTitle
import org.apache.texera.amber.core.tuple.{AttributeType, Schema}
import org.apache.texera.amber.pybuilder.PythonTemplateBuilder.PythonTemplateBuilderStringContext
import org.apache.texera.amber.pybuilder.PyStringTypes.EncodableString
Expand All @@ -31,13 +31,6 @@ import org.apache.texera.amber.operator.metadata.{OperatorGroupConstants, Operat
import org.apache.texera.amber.pybuilder.PythonTemplateBuilder

import javax.validation.constraints.NotNull
@JsonSchemaInject(json = """
{
"attributeTypeRules": {
"title": "string"
}
}
""")
class Scatter3dChartOpDesc extends PythonOperatorDescriptor {
@JsonProperty(value = "x", required = true)
@JsonSchemaTitle("X Column")
Expand Down
Loading