fix(agent-service): delete links targeting removed input ports when shrinking input ports - #7349
Open
VuMartin wants to merge 2 commits into
Open
fix(agent-service): delete links targeting removed input ports when shrinking input ports#7349VuMartin wants to merge 2 commits into
VuMartin wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
Backport auto-label reportThis
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7349 +/- ##
=========================================
Coverage 83.20% 83.20%
Complexity 4117 4117
=========================================
Files 1166 1166
Lines 46456 46462 +6
Branches 5177 5177
=========================================
+ Hits 38652 38658 +6
Misses 6097 6097
Partials 1707 1707
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@VuMartin Add screenshots? |
VuMartin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes a bug in
WorkflowState.updateOperatorInputPortswhere shrinking an operator's input port count left links targeting removed input ports. The method now removes any links whose target port no longer exists by callingdeleteLink, preventing dangling links from remaining in the workflow state.A regression test was also added to verify that links targeting deleted input ports are removed when the input port count is reduced.
Any related issues, documentation, discussions?
Closes #7169
How was this PR tested?
Added a regression test covering the case where an operator's input ports are reduced while a link targets one of the removed ports.
Verified with:
Before:
After:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT (5.5 mini)