Skip to content

feat(amber): return 404 for unavailable public workflow #8140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carloea2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(amber): return 404 for unavailable public workflow #8140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3474db3
fix(amber): return 404 for unavailable public workflow
carloea2 Aug 30, 2026
f3b17b8
test(amber): place public workflow regression
carloea2 Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,9 @@ class WorkflowResource extends LazyLogging {
.where(WORKFLOW.WID.eq(wid))
.and(WORKFLOW.IS_PUBLIC.isTrue)
.fetchOne()
if (workflow == null) {
throw new NotFoundException(s"Public workflow with id $wid not found")
Comment thread
carloea2 marked this conversation as resolved.
Comment thread
carloea2 marked this conversation as resolved.
}
WorkflowWithPrivilege(
workflow.getName,
workflow.getDescription,
Expand Down
6 changes: 6 additions & 0 deletions ...r/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,12 @@ class WorkflowResourceSpec
assertThrows[ForbiddenException](workflowResource.makePublic(wid, sessionUser2))
}

"WorkflowResource.retrievePublicWorkflow" should "hide private and missing workflows" in {
val wid = seedWorkflow(sessionUser1, "private-wf").workflow.getWid
assertThrows[NotFoundException](workflowResource.retrievePublicWorkflow(wid))
assertThrows[NotFoundException](workflowResource.retrievePublicWorkflow(wid + 100000))
}

"WorkflowResource.searchWorkflowByOperator" should "return only workflows whose content contains the operator" in {
val wid = seedWorkflow(
sessionUser1,
Expand Down
Loading