feat(pyamber): clean up reassigned channels - #8228
Conversation
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8228 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 4759 4759
=========================================
Files 1185 1185
Lines 48069 48072 +3
Branches 5359 5359
=========================================
+ Hits 45159 45162 +3
Misses 1480 1480
Partials 1430 1430
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 543 | 0.332 | 17,913/24,095/24,095 us | 🔴 +25.5% / 🔴 +54.7% |
| 🔴 | bs=100 sw=10 sl=64 | 1,209 | 0.738 | 79,438/106,672/106,672 us | 🔴 +5.4% / 🟢 -21.1% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,378 | 0.841 | 728,136/796,193/796,193 us | 🔴 +6.6% / 🟢 +32.2% |
Baseline details
Latest main 70c2114 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 543 tuples/sec | 596 tuples/sec | 787.98 tuples/sec | -8.9% | -31.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.332 MB/s | 0.364 MB/s | 0.481 MB/s | -8.8% | -31.0% |
| bs=10 sw=10 sl=64 | p50 | 17,913 us | 14,273 us | 12,593 us | +25.5% | +42.2% |
| bs=10 sw=10 sl=64 | p95 | 24,095 us | 28,544 us | 15,579 us | -15.6% | +54.7% |
| bs=10 sw=10 sl=64 | p99 | 24,095 us | 28,544 us | 18,786 us | -15.6% | +28.3% |
| bs=100 sw=10 sl=64 | throughput | 1,209 tuples/sec | 1,229 tuples/sec | 1,008 tuples/sec | -1.6% | +20.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.738 MB/s | 0.75 MB/s | 0.615 MB/s | -1.6% | +20.0% |
| bs=100 sw=10 sl=64 | p50 | 79,438 us | 79,848 us | 100,701 us | -0.5% | -21.1% |
| bs=100 sw=10 sl=64 | p95 | 106,672 us | 101,180 us | 107,244 us | +5.4% | -0.5% |
| bs=100 sw=10 sl=64 | p99 | 106,672 us | 101,180 us | 116,122 us | +5.4% | -8.1% |
| bs=1000 sw=10 sl=64 | throughput | 1,378 tuples/sec | 1,418 tuples/sec | 1,042 tuples/sec | -2.8% | +32.2% |
| bs=1000 sw=10 sl=64 | MB/s | 0.841 MB/s | 0.866 MB/s | 0.636 MB/s | -2.9% | +32.2% |
| bs=1000 sw=10 sl=64 | p50 | 728,136 us | 705,778 us | 981,959 us | +3.2% | -25.8% |
| bs=1000 sw=10 sl=64 | p95 | 796,193 us | 746,950 us | 1,023,080 us | +6.6% | -22.2% |
| bs=1000 sw=10 sl=64 | p99 | 796,193 us | 746,950 us | 1,051,697 us | +6.6% | -24.3% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,368.03,200,128000,543,0.332,17913.00,24094.65,24094.65
1,100,10,64,20,1654.35,2000,1280000,1209,0.738,79438.13,106671.63,106671.63
2,1000,10,64,20,14512.80,20000,12800000,1378,0.841,728135.84,796192.72,796192.72|
I am converting this PR to a draft: please follow our PR template and mark it ready for review. |
|
The description now follows the current template, and this is ready for review. |
What changes were proposed in this PR?
Remove a channel from its previous input port before registering it with another port. This keeps the forward mapping and each port's channel set consistent for port-aligned control messages.
Any related issues, documentation, discussions?
Closes #8227
How was this PR tested?
A direct post-fix probe confirmed both mapping directions agree:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex