feat(pyamber): return boolean table equality - #8232
Conversation
Automated Reviewer SuggestionsBased on the
|
Backport auto-label reportThis
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 396 | 0.242 | 23,377/43,827/43,827 us | 🔴 +32.6% / 🔴 +181.3% |
| 🔴 | bs=100 sw=10 sl=64 | 906 | 0.553 | 105,289/158,297/158,297 us | 🔴 +30.3% / 🔴 +47.6% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,093 | 0.667 | 917,738/976,382/976,382 us | ⚪ within ±5% / 🟢 -7.2% |
Baseline details
Latest main 70c2114 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 396 tuples/sec | 470 tuples/sec | 787.98 tuples/sec | -15.7% | -49.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.242 MB/s | 0.287 MB/s | 0.481 MB/s | -15.7% | -49.7% |
| bs=10 sw=10 sl=64 | p50 | 23,377 us | 19,204 us | 12,593 us | +21.7% | +85.6% |
| bs=10 sw=10 sl=64 | p95 | 43,827 us | 33,058 us | 15,579 us | +32.6% | +181.3% |
| bs=10 sw=10 sl=64 | p99 | 43,827 us | 33,058 us | 18,786 us | +32.6% | +133.3% |
| bs=100 sw=10 sl=64 | throughput | 906 tuples/sec | 977 tuples/sec | 1,008 tuples/sec | -7.3% | -10.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.553 MB/s | 0.596 MB/s | 0.615 MB/s | -7.2% | -10.1% |
| bs=100 sw=10 sl=64 | p50 | 105,289 us | 103,292 us | 100,701 us | +1.9% | +4.6% |
| bs=100 sw=10 sl=64 | p95 | 158,297 us | 121,486 us | 107,244 us | +30.3% | +47.6% |
| bs=100 sw=10 sl=64 | p99 | 158,297 us | 121,486 us | 116,122 us | +30.3% | +36.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,093 tuples/sec | 1,087 tuples/sec | 1,042 tuples/sec | +0.6% | +4.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.667 MB/s | 0.664 MB/s | 0.636 MB/s | +0.5% | +4.9% |
| bs=1000 sw=10 sl=64 | p50 | 917,738 us | 925,164 us | 981,959 us | -0.8% | -6.5% |
| bs=1000 sw=10 sl=64 | p95 | 976,382 us | 953,551 us | 1,023,080 us | +2.4% | -4.6% |
| bs=1000 sw=10 sl=64 | p99 | 976,382 us | 953,551 us | 1,051,697 us | +2.4% | -7.2% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,504.93,200,128000,396,0.242,23376.56,43826.72,43826.72
1,100,10,64,20,2206.63,2000,1280000,906,0.553,105289.06,158296.81,158296.81
2,1000,10,64,20,18296.55,20000,12800000,1093,0.667,917737.51,976381.84,976381.84|
I am converting this PR to a draft: please follow our PR template and mark it ready for review. |
|
The description now follows the current template, and this is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8232 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 4759 4759
=========================================
Files 1185 1185
Lines 48069 48069
Branches 5359 5359
=========================================
Hits 45159 45159
Misses 1480 1480
Partials 1430 1430
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What changes were proposed in this PR?
Reduce DataFrame equality across all rows and columns, then return a Python boolean. This makes
Table.__eq__match its declared contract and avoids ambiguous-Series failures in callers.Any related issues, documentation, discussions?
Closes #8231
How was this PR tested?
A direct post-fix probe covered equal and differing DataFrames:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex