feat(pyamber): report batch processing errors - #8298
Conversation
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8298 +/- ##
=========================================
Coverage 93.93% 93.93%
Complexity 4762 4762
=========================================
Files 1191 1191
Lines 48308 48310 +2
Branches 5377 5377
=========================================
+ Hits 45380 45382 +2
Misses 1494 1494
Partials 1434 1434
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 365 | 0.223 | 26,796/34,463/34,463 us | 🔴 +20.7% / 🔴 +121.2% |
| 🔴 | bs=100 sw=10 sl=64 | 784 | 0.478 | 126,139/164,965/164,965 us | 🔴 +7.0% / 🔴 +53.8% |
| ⚪ | bs=1000 sw=10 sl=64 | 914 | 0.558 | 1,085,778/1,156,456/1,156,456 us | ⚪ within ±5% / 🔴 +13.0% |
Baseline details
Latest main cb0b613 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 365 tuples/sec | 423 tuples/sec | 787.98 tuples/sec | -13.7% | -53.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.223 MB/s | 0.258 MB/s | 0.481 MB/s | -13.6% | -53.6% |
| bs=10 sw=10 sl=64 | p50 | 26,796 us | 22,200 us | 12,593 us | +20.7% | +112.8% |
| bs=10 sw=10 sl=64 | p95 | 34,463 us | 32,327 us | 15,579 us | +6.6% | +121.2% |
| bs=10 sw=10 sl=64 | p99 | 34,463 us | 32,327 us | 18,786 us | +6.6% | +83.4% |
| bs=100 sw=10 sl=64 | throughput | 784 tuples/sec | 829 tuples/sec | 1,008 tuples/sec | -5.4% | -22.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.478 MB/s | 0.506 MB/s | 0.615 MB/s | -5.5% | -22.3% |
| bs=100 sw=10 sl=64 | p50 | 126,139 us | 117,845 us | 100,701 us | +7.0% | +25.3% |
| bs=100 sw=10 sl=64 | p95 | 164,965 us | 161,436 us | 107,244 us | +2.2% | +53.8% |
| bs=100 sw=10 sl=64 | p99 | 164,965 us | 161,436 us | 116,122 us | +2.2% | +42.1% |
| bs=1000 sw=10 sl=64 | throughput | 914 tuples/sec | 926 tuples/sec | 1,042 tuples/sec | -1.3% | -12.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.558 MB/s | 0.565 MB/s | 0.636 MB/s | -1.2% | -12.3% |
| bs=1000 sw=10 sl=64 | p50 | 1,085,778 us | 1,080,403 us | 981,959 us | +0.5% | +10.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,156,456 us | 1,142,950 us | 1,023,080 us | +1.2% | +13.0% |
| bs=1000 sw=10 sl=64 | p99 | 1,156,456 us | 1,142,950 us | 1,051,697 us | +1.2% | +10.0% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,548.07,200,128000,365,0.223,26796.13,34462.64,34462.64
1,100,10,64,20,2551.71,2000,1280000,784,0.478,126138.83,164965.31,164965.31
2,1000,10,64,20,21887.03,20000,12800000,914,0.558,1085778.27,1156455.70,1156455.70
What changes were proposed in this PR?
Report per-row MainLoop failures through the worker exception path, enter exception pause, and stop consuming the affected batch.
Before: the worker logged the failure, continued later rows, and could finish with missing output.
After: the coordinator receives the error and the batch stops at the failed row.
Any related issues, documentation, discussions?
Closes #8297
How was this PR tested?
Added a regression covering the failure report, exception pause, and stopped batch consumption.
The focused regression passed. The full MainLoop test file was also run: 36 tests passed and 8 pre-existing integration cases failed during executor initialization because the shared generated protocol files do not yet contain
loop_start_port_uris.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex