chore(amber): remove the empty ExecutionStatusEnum.scala - #8435
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(amber): remove the empty ExecutionStatusEnum.scala#8435aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
The file has held nothing but the ASF license header since apache#1387 (2022-02-10) emptied it during the web-server state refactoring; apache#3415 (2025-05-03) later stamped the header onto the empty file. Nothing references the name anywhere in the tree.
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 519 | 0.317 | 18,069/25,847/25,847 us | 🔴 +10.2% / 🔴 +58.3% |
| 🔴 | bs=100 sw=10 sl=64 | 1,171 | 0.715 | 82,337/123,910/123,910 us | 🔴 +41.2% / 🟢 +21.0% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,380 | 0.843 | 722,582/864,840/864,840 us | 🔴 +17.6% / 🟢 +38.4% |
Baseline details
Latest main dcb25ef from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 519 tuples/sec | 558 tuples/sec | 749.39 tuples/sec | -7.0% | -30.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.317 MB/s | 0.341 MB/s | 0.457 MB/s | -7.0% | -30.7% |
| bs=10 sw=10 sl=64 | p50 | 18,069 us | 16,404 us | 13,045 us | +10.2% | +38.5% |
| bs=10 sw=10 sl=64 | p95 | 25,847 us | 28,050 us | 16,328 us | -7.9% | +58.3% |
| bs=10 sw=10 sl=64 | p99 | 25,847 us | 28,050 us | 19,518 us | -7.9% | +32.4% |
| bs=100 sw=10 sl=64 | throughput | 1,171 tuples/sec | 1,245 tuples/sec | 968.07 tuples/sec | -5.9% | +21.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.715 MB/s | 0.76 MB/s | 0.591 MB/s | -5.9% | +21.0% |
| bs=100 sw=10 sl=64 | p50 | 82,337 us | 80,746 us | 103,330 us | +2.0% | -20.3% |
| bs=100 sw=10 sl=64 | p95 | 123,910 us | 87,736 us | 110,305 us | +41.2% | +12.3% |
| bs=100 sw=10 sl=64 | p99 | 123,910 us | 87,736 us | 121,264 us | +41.2% | +2.2% |
| bs=1000 sw=10 sl=64 | throughput | 1,380 tuples/sec | 1,440 tuples/sec | 998 tuples/sec | -4.2% | +38.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.843 MB/s | 0.879 MB/s | 0.609 MB/s | -4.1% | +38.4% |
| bs=1000 sw=10 sl=64 | p50 | 722,582 us | 694,704 us | 1,009,354 us | +4.0% | -28.4% |
| bs=1000 sw=10 sl=64 | p95 | 864,840 us | 735,443 us | 1,052,748 us | +17.6% | -17.8% |
| bs=1000 sw=10 sl=64 | p99 | 864,840 us | 735,443 us | 1,081,982 us | +17.6% | -20.1% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,385.23,200,128000,519,0.317,18068.73,25846.69,25846.69
1,100,10,64,20,1708.37,2000,1280000,1171,0.715,82336.58,123909.53,123909.53
2,1000,10,64,20,14488.82,20000,12800000,1380,0.843,722581.86,864839.99,864839.99
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8435 +/- ##
============================================
- Coverage 94.03% 94.03% -0.01%
+ Complexity 4821 4819 -2
============================================
Files 1207 1207
Lines 49109 49109
Branches 5963 5963
============================================
- Hits 46180 46178 -2
Misses 1461 1461
- Partials 1468 1470 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
ExecutionStatusEnum.scala, an 18-line file that holds the ASF license header and nothing else — no code, and no reference to the name anywhere in the tree. Pure deletion, no behaviour change: −18 lines, none of them compiled. Flagged as a follow-up in the #8396 review.History
sealed trait ExecutionStatusEnumand its Jackson serializer/deserializer, carried byWorkflowStateEvent; #1423 (2022-02-01) reshaped it into asealed abstract classcarrying anameand a DB statuscodeWorkflowAggregatedState, changedWorkflowStateEvent.stateto aString, and left this file as a single blank line instead of deleting it. #3415 (2025-05-03) later stamped the ASF header onto the empty fileEmpty for about four and a half years. Like #8396, a file with zero compiled lines.
Any related issues, documentation, discussions?
Closes #8434
How was this PR tested?
No tests to change — the file had no code and no spec referenced it.
Locally, from the repo root with Java 17:
sbt "WorkflowExecutionService/Test/compile"— success.sbt "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check"— clean.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5.1)