THRIFT-3814 Fix contention in TNonblockingServerTest#1005
Closed
nsuke wants to merge 1 commit intoapache:masterfrom
Closed
THRIFT-3814 Fix contention in TNonblockingServerTest#1005nsuke wants to merge 1 commit intoapache:masterfrom
nsuke wants to merge 1 commit intoapache:masterfrom
Conversation
| ++port; | ||
| startServer(retry_count - 1); | ||
| } else { | ||
| throw; |
Contributor
There was a problem hiding this comment.
Seems bad to throw an unhandled exception from a thread, but maybe this is catastrophic and rare enough that this is fine? The rest of the change looks good to me.
Member
Author
There was a problem hiding this comment.
It's a test failure so my intention here was "no need to catch" and let it die with std::terminate with exception log.
The original error flag was needed for retrying from the main thread.
tpcwang
pushed a commit
to tpcwang/thrift
that referenced
this pull request
Jun 14, 2016
karlmutch
added a commit
to karlmutch/thrift
that referenced
this pull request
Jun 23, 2016
* THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64 Client: Dart Patch: Steven Osborne <steven.osborne@webfilings.com> This closes apache#983 * Revert "THRIFT-3746 JSON protocol left in incorrect state on read errors" This reverts commit 51850ab. * THRIFT-3786: Node TLS emits 'connect' before connection is ready Client: Node Patch: James Reggio This closes apache#985 commit b76bad7 Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-11T17:53:12Z THRIFT-3786 Fix premature firing of `connect` event for secure sockets * THRIFT-2821: Add HTTP header support to JavaScript lib Client: JavaScript lib Patch: David Sautter Adds a customHeaders field to the XHR transport options supporting multiple key-value custom HTTP headers to pass with the request. * THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi Patch: Nick Homolibere Tested on XE, XE5, XE8, XE10 This closes apache#987 * THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi Patch: Jens Geyer Revised previous patch. * THRIFT-3559 Fix awkward extra semi-colons with Cocoa container literals Client: Cocoa Patch: Kevin Wooten This closes apache#797 * THRIFT-3791 Delphi pipe client may fail even in a non-error condition Client: Delphi Patch: Kyle Johnson * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Kyle Johnson & Jens Geyer * THRIFT-3792 Timeouts for anonymous pipes should be configurable Client: Delphi Patch: Kyle Johnson * THRIFT-3487 Full support for newer Delphi versions Client: Delphi Patch: Kyle Johnson Slight refactoring plus some IFDEFs and the missing ASF header added by Jens Geyer * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Jens Geyer Added separate "open" timeout to have the ability to decouple pipe connection timeouts from tramsmission timeouts. * THRIFT-3793: move to ant-1.9.7 for appveyor builds Client: Build process Patch: Jim King <jim.king@simplivity.com> This closes apache#990 * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Kyle Johnson The final fix. * THRIFT-3794 Split Delphi application, protocol and transport exception subtypes into separate exceptions Client: Delphi Patch: Kyle Johnson * THRIFT-3795 Generated hashValue method in Swift will overflow Client: Swift Patch: Håkon Hitland * THRIFT-3796 There's no --dbg for dh_strip, maybe someone has mistaken this for --dbg-package. Client: Build process Patch: Akira <matyapiro31@...> This closes apache#988 * THRIFT-3794 Fixing exception types in library now that they have been split up Client: Delphi Patch: Kyle Johnson <kyle@powerworld.com> This closes apache#993 * THRIFT-3797 Generated Delphi processor shouldn't error out on timed out exceptions Client: Delphi Patch: Kyle Johnson This closes apache#994 * THRIFT-3808 Missing `DOUBLE` in thrift type enumeration Client: Go Patch: Mahendran Kathirvel <astromahi@gmail.com> This closes apache#1001 * THRIFT-3809 wrong/unused BINARY type code Client: Go Patch: Jens Geyer * THRIFT-3807 Swift compiler does not escape reserved words Client: Swift Patch: Stig Bakken <stig@zedge.net> This closes apache#998 * THRIFT-3806 Swift generator does not handle self-referring structs Client: Swift Patch: Stig Bakken <stig@zedge.net> This closes apache#997 * THRIFT-3803 - Remove file attribute from include elements in XML generator Client: XML/XSD Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#996 * THRIFT-3533 Can not send nil pointer as service method argument Client: Go Patch: Chris Bannister * THRIFT-3813: fix appveyor dependency on external openssl installer that was revved This closes apache#1004 * THRIFT-3789: Add destroy connection feature to node Client: Nodejs Patch: James Reggio Github Pull Request: This closes apache#989 commit b2907fd Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-18T19:49:50Z THRIFT-3789 Add `destroy` to Connection instance This commit proxies the `destroy` method from the Thrift Connection object to its underlying socket, akin to the existing `end` method. Without `destroy`, it's possible for a failed TLS socket to hold the Node.js process open. (Calling `end` is not sufficient to close the OS handle because `end` sends a FIN packet, which is never acknowledged by the server.) * THRIFT-3787: connection close code fix for ssl CLIENT: Node PATCH: JAMES REGGIO james.reggio@gmail.com This closes apache#986 commit 449b1d7 Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-13T23:33:40Z THRIFT-3787 Fix Node.js Connection object error handling The `connected` property on a Connection instances was not accurately maintained if reconnection retries are not enabled. Furthermore, reconnection retries are not possible with secure sockets, so this commit returns early in that case, preventing long delays. * THRIFT-3814 Fix contention in TNonblockingServerTest This closes apache#1005 * THRIFT-3816 Reduce docker build duration on Travis-CI This closes apache#1007 * THRIFT-3815 Put appveyor dependency versions to one place This closes apache#1006 * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen * THRIFT-3841 Dart compact protocol incorrectly serializes/deserialized doubles Client: Dart Patch: Brian Shannan <brian.shannan@workiva.com> This closes #3841 * THRIFT-3842 Dart generates incorrect code for a const struct Client: Dart Patch: Mark Erickson <merickson@apache.org> This closes apache#1019 * THRIFT-3805 Golang server susceptible to memory spike from malformed message Client: Go Patch: Michael Scott Leuthaeuser <scott.leuthaeuser@gmail.com> * THRIFT-3843 integer issues with Haxe PHP targets cause ZigZag encoding to fail Client: Haxe Patch: Jens Geyer * THRIFT-3833 haxe http server implementation (by embeding into php web server) Client: Haxe Patch: Oleksii Prudkyi <Oleksii.Prudkyi@gmail.com> + some modifications by Jens Geyer This closes apache#1013 This closes apache#1020 * Revert "THRIFT-3834 Erlang namespacing and exception metadata" This reverts commit 8e23203. * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen * Revert "THRIFT-3834 Erlang namespacing and exception metadata" This reverts commit c8deed8. * THRIFT-3849 Port Go serializer and deserializer to Dart Client: Dart Patch: Keaton Carter <keaton.carter@workiva.com> This closes apache#1023 * THRIFT-3825 Javascript test dependency is no longer available * THRIFT-3852 A Travis-CI job fails with "write error" * THRIFT-3233 fix accounting of workers in thread manager Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#992 * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen <steve@pinterest.com> This closes apache#1027 * THRIFT-3768 fix TThreadedServer refactoring issues with client lifetime guarantees Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#977 * THRIFT-3753 TServerFramework::stop may fail to interrupt connected clients Client: C++ Patch: tpcwang <tpc.wang@gmail.com> This closes apache#959 * THRIFT-3750 Check isSet in copyWithZone Client: Cocoa Patch: Zach Howe <zach@zachhowe.com> This closes apache#958
karlmutch
added a commit
to karlmutch/thrift
that referenced
this pull request
Jun 23, 2016
* THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64 Client: Dart Patch: Steven Osborne <steven.osborne@webfilings.com> This closes apache#983 * Revert "THRIFT-3746 JSON protocol left in incorrect state on read errors" This reverts commit 51850ab. * THRIFT-3786: Node TLS emits 'connect' before connection is ready Client: Node Patch: James Reggio This closes apache#985 commit b76bad7 Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-11T17:53:12Z THRIFT-3786 Fix premature firing of `connect` event for secure sockets * THRIFT-2821: Add HTTP header support to JavaScript lib Client: JavaScript lib Patch: David Sautter Adds a customHeaders field to the XHR transport options supporting multiple key-value custom HTTP headers to pass with the request. * THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi Patch: Nick Homolibere Tested on XE, XE5, XE8, XE10 This closes apache#987 * THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi Patch: Jens Geyer Revised previous patch. * THRIFT-3559 Fix awkward extra semi-colons with Cocoa container literals Client: Cocoa Patch: Kevin Wooten This closes apache#797 * THRIFT-3791 Delphi pipe client may fail even in a non-error condition Client: Delphi Patch: Kyle Johnson * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Kyle Johnson & Jens Geyer * THRIFT-3792 Timeouts for anonymous pipes should be configurable Client: Delphi Patch: Kyle Johnson * THRIFT-3487 Full support for newer Delphi versions Client: Delphi Patch: Kyle Johnson Slight refactoring plus some IFDEFs and the missing ASF header added by Jens Geyer * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Jens Geyer Added separate "open" timeout to have the ability to decouple pipe connection timeouts from tramsmission timeouts. * THRIFT-3793: move to ant-1.9.7 for appveyor builds Client: Build process Patch: Jim King <jim.king@simplivity.com> This closes apache#990 * THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist Client: Delphi Patch: Kyle Johnson The final fix. * THRIFT-3794 Split Delphi application, protocol and transport exception subtypes into separate exceptions Client: Delphi Patch: Kyle Johnson * THRIFT-3795 Generated hashValue method in Swift will overflow Client: Swift Patch: Håkon Hitland * THRIFT-3796 There's no --dbg for dh_strip, maybe someone has mistaken this for --dbg-package. Client: Build process Patch: Akira <matyapiro31@...> This closes apache#988 * THRIFT-3794 Fixing exception types in library now that they have been split up Client: Delphi Patch: Kyle Johnson <kyle@powerworld.com> This closes apache#993 * THRIFT-3797 Generated Delphi processor shouldn't error out on timed out exceptions Client: Delphi Patch: Kyle Johnson This closes apache#994 * THRIFT-3808 Missing `DOUBLE` in thrift type enumeration Client: Go Patch: Mahendran Kathirvel <astromahi@gmail.com> This closes apache#1001 * THRIFT-3809 wrong/unused BINARY type code Client: Go Patch: Jens Geyer * THRIFT-3807 Swift compiler does not escape reserved words Client: Swift Patch: Stig Bakken <stig@zedge.net> This closes apache#998 * THRIFT-3806 Swift generator does not handle self-referring structs Client: Swift Patch: Stig Bakken <stig@zedge.net> This closes apache#997 * THRIFT-3803 - Remove file attribute from include elements in XML generator Client: XML/XSD Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#996 * THRIFT-3533 Can not send nil pointer as service method argument Client: Go Patch: Chris Bannister * THRIFT-3813: fix appveyor dependency on external openssl installer that was revved This closes apache#1004 * THRIFT-3789: Add destroy connection feature to node Client: Nodejs Patch: James Reggio Github Pull Request: This closes apache#989 commit b2907fd Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-18T19:49:50Z THRIFT-3789 Add `destroy` to Connection instance This commit proxies the `destroy` method from the Thrift Connection object to its underlying socket, akin to the existing `end` method. Without `destroy`, it's possible for a failed TLS socket to hold the Node.js process open. (Calling `end` is not sufficient to close the OS handle because `end` sends a FIN packet, which is never acknowledged by the server.) * THRIFT-3787: connection close code fix for ssl CLIENT: Node PATCH: JAMES REGGIO james.reggio@gmail.com This closes apache#986 commit 449b1d7 Author: James Reggio <james.reggio@gmail.com> Date: 2016-04-13T23:33:40Z THRIFT-3787 Fix Node.js Connection object error handling The `connected` property on a Connection instances was not accurately maintained if reconnection retries are not enabled. Furthermore, reconnection retries are not possible with secure sockets, so this commit returns early in that case, preventing long delays. * THRIFT-3814 Fix contention in TNonblockingServerTest This closes apache#1005 * THRIFT-3816 Reduce docker build duration on Travis-CI This closes apache#1007 * THRIFT-3815 Put appveyor dependency versions to one place This closes apache#1006 * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen * THRIFT-3841 Dart compact protocol incorrectly serializes/deserialized doubles Client: Dart Patch: Brian Shannan <brian.shannan@workiva.com> This closes #3841 * THRIFT-3842 Dart generates incorrect code for a const struct Client: Dart Patch: Mark Erickson <merickson@apache.org> This closes apache#1019 * THRIFT-3805 Golang server susceptible to memory spike from malformed message Client: Go Patch: Michael Scott Leuthaeuser <scott.leuthaeuser@gmail.com> * THRIFT-3843 integer issues with Haxe PHP targets cause ZigZag encoding to fail Client: Haxe Patch: Jens Geyer * THRIFT-3833 haxe http server implementation (by embeding into php web server) Client: Haxe Patch: Oleksii Prudkyi <Oleksii.Prudkyi@gmail.com> + some modifications by Jens Geyer This closes apache#1013 This closes apache#1020 * Revert "THRIFT-3834 Erlang namespacing and exception metadata" This reverts commit 8e23203. * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen * Revert "THRIFT-3834 Erlang namespacing and exception metadata" This reverts commit c8deed8. * THRIFT-3849 Port Go serializer and deserializer to Dart Client: Dart Patch: Keaton Carter <keaton.carter@workiva.com> This closes apache#1023 * THRIFT-3825 Javascript test dependency is no longer available * THRIFT-3852 A Travis-CI job fails with "write error" * THRIFT-3233 fix accounting of workers in thread manager Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#992 * THRIFT-3834 Erlang namespacing and exception metadata Client: Erlang Patch: Steve Cohen <steve@pinterest.com> This closes apache#1027 * THRIFT-3768 fix TThreadedServer refactoring issues with client lifetime guarantees Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#977 * THRIFT-3753 TServerFramework::stop may fail to interrupt connected clients Client: C++ Patch: tpcwang <tpc.wang@gmail.com> This closes apache#959 * THRIFT-3750 Check isSet in copyWithZone Client: Cocoa Patch: Zach Howe <zach@zachhowe.com> This closes apache#958 * Make java version to match DC version * 0.3.0-dc
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Jan 24, 2017
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
* Minor spelling fixes. * Small typo in Literals.cs .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.