THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift#1174
Closed
jeking3 wants to merge 1 commit intoapache:masterfrom
Closed
THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift#1174jeking3 wants to merge 1 commit intoapache:masterfrom
jeking3 wants to merge 1 commit intoapache:masterfrom
Conversation
swatkatz
pushed a commit
to swatkatz/thrift
that referenced
this pull request
Feb 9, 2017
Client: Build This closes apache#1174
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: Build This closes apache#1174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the mkdir, perl5 was being moved to /usr/lib directly, rather than being moved INTO /usr/lib. This caused perl to go into /usr/lib/Thrift.pm and /usr/lib/Thrift/... instead.
Also, debian wants architecture independent files in /usr/share, so I changed it to use /usr/share/perl5 to match the debian packaging desires.