THRIFT-4079 add missing use clauses for included thrift sources in generated perl modules#1181
Closed
jeking3 wants to merge 1 commit intoapache:masterfrom
Closed
THRIFT-4079 add missing use clauses for included thrift sources in generated perl modules#1181jeking3 wants to merge 1 commit intoapache:masterfrom
jeking3 wants to merge 1 commit intoapache:masterfrom
Conversation
…nerated perl modules
Contributor
Author
|
Job 3357.7 failure appears environmental: make[3]: write error |
swatkatz
pushed a commit
to swatkatz/thrift
that referenced
this pull request
Feb 9, 2017
…nerated perl modules Client: perl This closes apache#1181
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
…nerated perl modules Client: perl This closes apache#1181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sadly the state of perl unit testing appears to be pretty sad... I don't see any tests for perl being run with "make check", nor are they run in the perl package maker (for cpan installs). There are three test files but I'm not sure how they get run, if at all. So there's no test for this. I tested it on the example I submitted and it resolves the issue.