Skip to content

Conversation

@emmenlau
Copy link
Member

@emmenlau emmenlau commented Apr 7, 2017

Use mingw-w64-xxx variants of openssl and zlib on MSYS2 build for Windows

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed; packages not found.

--needed -S bison flex ^
make ^
openssl openssl-devel ^
mingw-w64-openssl ^
Copy link
Contributor

@jeking3 jeking3 Apr 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingw-w64-x86_64-openssl perhaps Don't forget the dev / devel package which will have the headers and link libraries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the missing architecture! Fixed in latest PR.
The mingw-w64 variants of packages do not use dev / devel package.

mingw-w64-x86_64-cmake ^
mingw-w64-x86_64-toolchain ^
zlib zlib-devel
mingw-w64-zlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingw-w64-x86_64-zlib (and zlib-devel or whatever it's called for mingw) perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the missing architecture! Fixed in latest PR.
The mingw-w64 variants of packages do not use dev / devel package.

@jeking3
Copy link
Contributor

jeking3 commented Apr 15, 2017

This PR needs an update so it can rebuild and pass.

@emmenlau
Copy link
Member Author

Should be working now.

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis CI failure (not related to the PR) is THRIFT-4155: "Unstable D language test has caused some CI build failures."

The msys2/mingw64 readme in the build directory should also be changed but I can do that when I merge into master.

@asfgit asfgit closed this in a105450 Apr 18, 2017
@emmenlau emmenlau deleted the THRIFT-4158 branch April 18, 2017 14:55
@emmenlau
Copy link
Member Author

Thanks!

jeking3 pushed a commit to jeking3/thrift that referenced this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants