-
Notifications
You must be signed in to change notification settings - Fork 4.1k
MSYS-appveyor-install.bat: use mingw-w64-xxx variants #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeking3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed; packages not found.
| --needed -S bison flex ^ | ||
| make ^ | ||
| openssl openssl-devel ^ | ||
| mingw-w64-openssl ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mingw-w64-x86_64-openssl perhaps Don't forget the dev / devel package which will have the headers and link libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing the missing architecture! Fixed in latest PR.
The mingw-w64 variants of packages do not use dev / devel package.
| mingw-w64-x86_64-cmake ^ | ||
| mingw-w64-x86_64-toolchain ^ | ||
| zlib zlib-devel | ||
| mingw-w64-zlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mingw-w64-x86_64-zlib (and zlib-devel or whatever it's called for mingw) perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing the missing architecture! Fixed in latest PR.
The mingw-w64 variants of packages do not use dev / devel package.
|
This PR needs an update so it can rebuild and pass. |
|
Should be working now. |
jeking3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Travis CI failure (not related to the PR) is THRIFT-4155: "Unstable D language test has caused some CI build failures."
The msys2/mingw64 readme in the build directory should also be changed but I can do that when I merge into master.
|
Thanks! |
… openssl and zlib Client: C++ This closes apache#1247
Use mingw-w64-xxx variants of openssl and zlib on MSYS2 build for Windows