THRIFT-4193 Set default max read buffer size in Java server #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the non-blocking server.
roshan
changed the title
jeking3
approved these changes
May 10, 2017
Contributor
jeking3
left a comment
jeking3
left a comment
There was a problem hiding this comment.
even 256MB seems like a huge I/O buffer to allow... shouldn't this be configurable by the consuming application?
Contributor
Author
|
It is configurable using the EDIT: Actually, that doesn't have a setter, but you can manipulate it directly. |
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Aug 5, 2017
…vers Client: Java Patch: Roshan George <rgeorge@liveramp.com> This closes apache#1264
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
…vers Client: Java Patch: Roshan George <rgeorge@liveramp.com> This closes apache#1264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the non-blocking server. This makes it so that just starting up something with all defaults won't result in it being possible to construct an input that causes it to OOME by just filling up the read buffer.