Update TByteBuffer.java #1290
Closed
Update TByteBuffer.java #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
approved these changes
Jun 16, 2017
Contributor
jeking3
left a comment
jeking3
left a comment
There was a problem hiding this comment.
Looks fundamentally broken without this fix. Please open a Jira ticket following the instructions at
Contributor
|
@jeking3 gah, sorry -- believe this was lifted from another code base, possible we fixed this downstream without pushing it back up after the original PR landed. @gx9702 I can go through the full HtC process if you don't have time since I'm the dimwit that messed this up first time around. Let me know either way. |
Contributor
|
Normally I would ask for a new Jira ticket to be filed by the submitter, but this is pretty obvious and pretty serious, so I did it: THRIFT-4316 |
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: java This closes apache#1290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix buffer read bug