configure.ac, Makefile.am: introduce THRIFT variable to support cross… #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-compilation The thrift build system currently assumes that the thrift compiler is always available in $(top_builddir)/compiler/cpp/thrift. However, in a cross-compilation context, this location contains the thrift compiler built for the target... which obviously will not run on the build machine. In order to support such cross-compilation situation, we introduce the THRIFT variable as a an argument for the configure script (using AC_ARG_VAR). If not specified, it defaults to the existing value of using compiler/cpp/thrift from the build directory, but it can be overridden when calling ./configure. Note that $(top_builddir) cannot be used within the configure script, so we simply use `pwd`, which is the same as the top_builddir. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Contributor
|
Wouldn't we want the value in configure.ac to percolate through? Why override it in every Makefile.am? |
Contributor
Author
|
Well, my patch precisely removes the override in every Makefile.am, so I'm not sure to understand your question. |
Contributor
|
Thanks, it was late when I posted the comment and I misread the change! If there's any way you could rebase on master, squash, and force push that will kick off another CI build to validate the fix. |
Contributor
|
I like the changes as proposed; this needs an Apache Jira ticket stating the problem and resolution in order to get merged. https://thrift.apache.org/docs/HowToContribute Thanks! |
jeking3
approved these changes
Sep 6, 2017
Contributor
|
I opened THRIFT-4325 for this. |
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
…-compilation The thrift build system currently assumes that the thrift compiler is always available in $(top_builddir)/compiler/cpp/thrift. However, in a cross-compilation context, this location contains the thrift compiler built for the target... which obviously will not run on the build machine. In order to support such cross-compilation situation, we introduce the THRIFT variable as a an argument for the configure script (using AC_ARG_VAR). If not specified, it defaults to the existing value of using compiler/cpp/thrift from the build directory, but it can be overridden when calling ./configure. Note that $(top_builddir) cannot be used within the configure script, so we simply use `pwd`, which is the same as the top_builddir. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> This closes apache#1336 This closes apache#1350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-compilation
The thrift build system currently assumes that the thrift compiler is
always available in $(top_builddir)/compiler/cpp/thrift. However, in a
cross-compilation context, this location contains the thrift compiler
built for the target... which obviously will not run on the build
machine.
In order to support such cross-compilation situation, we introduce the
THRIFT variable as a an argument for the configure script (using
AC_ARG_VAR). If not specified, it defaults to the existing value of
using compiler/cpp/thrift from the build directory, but it can be
overridden when calling ./configure.
Note that $(top_builddir) cannot be used within the configure script,
so we simply use
pwd, which is the same as the top_builddir.Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com