THRIFT-4367 Fix missing positional argument #1392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
requested changes
Oct 20, 2017
Contributor
|
Please see: https://thrift.apache.org/docs/HowToContribute This does not have an associated Thrift Jira issue and is not properly named. Recommend you fix these issues then rebase against master to resolve some of the CI issues. |
jeking3
approved these changes
Oct 20, 2017
Contributor
jeking3
left a comment
jeking3
left a comment
There was a problem hiding this comment.
Change looks good, just need CI to pass.
Contributor
|
I opened THRIFT-4367 for this. |
3013216027
changed the title
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
TProcessor.process Client: py Patch: Qyetfu This closes apache#1392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the function process in the base TProcessor is missing a "self" argument.