THRIFT-4463: generate PHP code match psr2#1473
Closed
robberphex wants to merge 1 commit intoapache:masterfrom
Closed
THRIFT-4463: generate PHP code match psr2#1473robberphex wants to merge 1 commit intoapache:masterfrom
robberphex wants to merge 1 commit intoapache:masterfrom
Conversation
robberphex
changed the title
* PHP ident with 4 space * remove redundancy blank lines * open bracket of function, class at new line * remove hard-coded indent, use indent() * add necessary visibility declaration for class field * open bracket of flow control put end of line, not new line * remove inline control structures * add blank around equal symbol
jeking3
approved these changes
Jan 24, 2018
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Mar 10, 2018
Client: php * PHP ident with 4 space * remove redundancy blank lines * open bracket of function, class at new line * remove hard-coded indent, use indent() * add necessary visibility declaration for class field * open bracket of flow control put end of line, not new line * remove inline control structures * add blank around equal symbol This closes apache#1473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://issues.apache.org/jira/browse/THRIFT-4463